kie-kogito-runtimes-3388: Improve serverless workflows timeouts durat…

…ion validation message (#3433) * kie-kogito-runtimes-3388: Improve serverless workflows timeouts duration validation message * Formatting fixes in classes not related to this PR
apache · Mar 11, 2024 · ccdd173 · ccdd173
1 parent 0ff99d1
commit ccdd173
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/...uilder/src/main/java/org/kie/kogito/serverless/workflow/utils/TimeoutsConfigResolver.java b/...uilder/src/main/java/org/kie/kogito/serverless/workflow/utils/TimeoutsConfigResolver.java
@@ -30,7 +30,10 @@
 public class TimeoutsConfigResolver {
 
     private static final String NON_NEGATIVE_DURATION_MUST_BE_PROVIDED =
-            "When configured, it must be set with a greater than zero ISO 8601 time duration. For example PT30S. Or a valid expression, for example $CONST.myDuration, where 'myDuration' is defined in the constant section of the workflow";
+            "When configured, it must be set with a greater than zero ISO 8601 time duration. For example PT30S." +
+                    " Or a valid expression, for example $CONST.myDuration, where 'myDuration' is defined in the constant section of the workflow." +
+                    " Note: month based durations like P2M (period of two months) are not valid since the month duration might vary." +
+                    " In that case you can use PT60D instead.";
 
     private static final String INVALID_EVENT_TIMEOUT_FOR_STATE_ERROR = "An invalid \"eventTimeout\": \"%s\" configuration was provided for the state \"%s\" in the serverless workflow: \"%s\"." +
             NON_NEGATIVE_DURATION_MUST_BE_PROVIDED;

diff --git a/...loyment/src/main/java/org/kie/kogito/quarkus/common/deployment/KogitoAssetsProcessor.java b/...loyment/src/main/java/org/kie/kogito/quarkus/common/deployment/KogitoAssetsProcessor.java
@@ -107,7 +107,7 @@ public class KogitoAssetsProcessor {
     @BuildStep
     public KogitoBuildContextBuildItem generateKogitoBuildContext(List<KogitoBuildContextAttributeBuildItem> attributes) {
         // configure the application generator
-        PathCollection rootPaths = getRootPaths( root.getResolvedPaths());
+        PathCollection rootPaths = getRootPaths(root.getResolvedPaths());
         KogitoBuildContext context =
                 kogitoBuildContext(outputTargetBuildItem.getOutputDirectory(),
                         rootPaths,

diff --git a/...ent/src/test/java/org/kie/kogito/quarkus/common/deployment/KogitoAssetsProcessorTest.java b/...ent/src/test/java/org/kie/kogito/quarkus/common/deployment/KogitoAssetsProcessorTest.java
@@ -4,9 +4,10 @@
 import java.nio.file.Path;
 import java.util.Arrays;
 
+import org.junit.jupiter.api.Test;
+
 import io.quarkus.bootstrap.model.PathsCollection;
 import io.quarkus.paths.PathCollection;
-import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -43,4 +44,4 @@ void getRootPathsWithClasses() {
         String expectedPath = String.format("%s/%s/generated-resources", projectDirPath, outputTargetPath).replace("/", File.separator);
         assertTrue(retrieved.contains(Path.of(expectedPath)));
     }
-}
+}