Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hstore): JRaft maxEntriesSize configuration parameters do not take effect #2630

Merged
merged 13 commits into from
Aug 11, 2024

Conversation

JackyYangPassion
Copy link
Contributor

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. store Store module labels Aug 10, 2024
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 10, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Aug 10, 2024
@JackyYangPassion JackyYangPassion marked this pull request as draft August 10, 2024 05:00
@JackyYangPassion JackyYangPassion marked this pull request as ready for review August 10, 2024 07:44
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.96%. Comparing base (7df736a) to head (c530410).

Files Patch % Lines
.../hugegraph/store/options/HgStoreEngineOptions.java 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (7df736a) and HEAD (c530410). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (7df736a) HEAD (c530410)
5 3
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #2630       +/-   ##
=============================================
- Coverage     46.97%   35.96%   -11.02%     
+ Complexity      468      302      -166     
=============================================
  Files           729      718       -11     
  Lines         59508    58441     -1067     
  Branches       7659     7492      -167     
=============================================
- Hits          27953    21016     -6937     
- Misses        28722    35100     +6378     
+ Partials       2833     2325      -508     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -28,7 +28,8 @@ github:
del_branch_on_merge: true
#labels:
enabled_merge_buttons:
merge: false
# TODO: disable it after common merged
merge: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we don't need to change in this commit

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we don't need to change in this commit

Since another PR is blocked now

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 11, 2024
@VGalaxies VGalaxies merged commit a038d23 into apache:master Aug 11, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. store Store module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Bug] JRaft maxEntriesSize configuration parameters do not take effect
4 participants