chore: fix lombok compiling error #2592
Conversation
dosubot
bot
added
size:S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2592 +/- ##
============================================
+ Coverage 46.93% 47.21% +0.27%
- Complexity 343 583 +240
============================================
Files 718 718
Lines 58469 58469
Branches 7496 7496
============================================
+ Hits 27445 27605 +160
+ Misses 28242 28083 -159
+ Partials 2782 2781 -1 ☔ View full report in Codecov by Sentry. |
hugegraph-pd/hg-pd-client/pom.xml
Outdated
| @@ -34,7 +34,7 @@ | |||
| <dependency> | |||
| <groupId>org.projectlombok</groupId> | |||
| <artifactId>lombok</artifactId> | |||
| <version>1.18.20</version> | |||
| <version>1.18.30</version> | |||
There was a problem hiding this comment.
Shall we use a unified version property for it?
hugegraph-pd/hg-pd-client/pom.xml
Outdated
| @@ -34,7 +34,7 @@ | |||
| <dependency> | |||
| <groupId>org.projectlombok</groupId> | |||
| <artifactId>lombok</artifactId> | |||
| <version>1.18.20</version> | |||
| <version>1.18.30</version> | |||
There was a problem hiding this comment.
Can we remove the lombok dependency:
since we don't have a large places to generate/replace code, and in the few places where it's necessary, I would rather write some code manually to maintain a consistent style.
|
@zyxxoo The version also needs to be bumped in hg-pd-common. |
dosubot
bot
added
size:M
zyxxoo
force-pushed
the
fix_vaughn
branch
2 times, most recently
from
c2dc5a7
to
c33376f
Compare
dosubot
bot
added
size:L
| <dependency> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>1.18.30</version> |
There was a problem hiding this comment.
Maybe we could add <optional>true</optional> and provide scope for it?
There was a problem hiding this comment.
the optional mean don't transfer dependency, for example, A -> B -> C, if B. use. optional true to c, the A will not reference C
so the optional in our code maybe don't importament
hugegraph-store/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>1.18.30</version> |
There was a problem hiding this comment.
no, the code is in dependencymanager
fix Fatal error compiling: java.lang.NoSuchFieldError: Class com.sun.tools.javac.tree.JCTree$JCImport does not have member field 'com.sun.tools.javac.tree.JCTree qualid' error