-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix lombok compiling error #2592
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2592 +/- ##
============================================
+ Coverage 46.93% 47.21% +0.27%
- Complexity 343 583 +240
============================================
Files 718 718
Lines 58469 58469
Branches 7496 7496
============================================
+ Hits 27445 27605 +160
+ Misses 28242 28083 -159
+ Partials 2782 2781 -1 ☔ View full report in Codecov by Sentry. |
hugegraph-pd/hg-pd-client/pom.xml
Outdated
@@ -34,7 +34,7 @@ | |||
<dependency> | |||
<groupId>org.projectlombok</groupId> | |||
<artifactId>lombok</artifactId> | |||
<version>1.18.20</version> | |||
<version>1.18.30</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use a unified version property for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
hugegraph-pd/hg-pd-client/pom.xml
Outdated
@@ -34,7 +34,7 @@ | |||
<dependency> | |||
<groupId>org.projectlombok</groupId> | |||
<artifactId>lombok</artifactId> | |||
<version>1.18.20</version> | |||
<version>1.18.30</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the lombok dependency:
since we don't have a large places to generate/replace code, and in the few places where it's necessary, I would rather write some code manually to maintain a consistent style.
@zyxxoo The version also needs to be bumped in hg-pd-common. |
c2dc5a7
to
c33376f
Compare
<dependency> | ||
<groupId>org.projectlombok</groupId> | ||
<artifactId>lombok</artifactId> | ||
<version>1.18.30</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could add <optional>true</optional>
and provide
scope for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the optional mean don't transfer dependency, for example, A -> B -> C, if B. use. optional true to c, the A will not reference C
so the optional in our code maybe don't importament
hugegraph-store/pom.xml
Outdated
<dependency> | ||
<groupId>org.projectlombok</groupId> | ||
<artifactId>lombok</artifactId> | ||
<version>1.18.30</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
miss here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, the code is in dependencymanager
fix Fatal error compiling: java.lang.NoSuchFieldError: Class com.sun.tools.javac.tree.JCTree$JCImport does not have member field 'com.sun.tools.javac.tree.JCTree qualid' error