doc(pd): add initial-store-count comments in application.yml
#2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PD cluster will assess the overall health of the cluster. If the number of store nodes is less than the initial-store-count, the cluster will be unavailable
dosubot
bot
added
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2587 +/- ##
=============================================
- Coverage 52.49% 39.48% -13.01%
- Complexity 586 635 +49
=============================================
Files 643 643
Lines 53393 53393
Branches 7018 7018
=============================================
- Hits 28026 21081 -6945
- Misses 22538 30015 +7477
+ Partials 2829 2297 -532 ☔ View full report in Codecov by Sentry. |
imbajin
changed the title
imbajin
changed the title
initial-store-count comments in application.yml
VGalaxies
reviewed
Jul 15, 2024
| @@ -70,7 +70,6 @@ store: | |||
| monitor_data_interval: 1 minute | |||
| # Retention time of monitoring data is 1 day; day, month, year | |||
| monitor_data_retention: 1 day | |||
| initial-store-count: 1 | |||
There was a problem hiding this comment.
TODO: remove store.initial-store-count in other similar conf files
VGalaxies
approved these changes
Jul 15, 2024
imbajin
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2579
PD cluster will assess the overall health of the cluster. If the number of store nodes is less than the initial-store-count, the cluster will be unavailable