Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade revision to 1.5.0 #2585

Merged
merged 2 commits into from
Jul 13, 2024
Merged

chore: upgrade revision to 1.5.0 #2585

merged 2 commits into from
Jul 13, 2024

Conversation

VGalaxies
Copy link
Contributor

Copy link

codecov bot commented Jul 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.87%. Comparing base (9f89afc) to head (2495a68).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2585      +/-   ##
============================================
+ Coverage     52.97%   56.87%   +3.90%     
- Complexity      827     1222     +395     
============================================
  Files           643      643              
  Lines         53387    53387              
  Branches       7018     7018              
============================================
+ Hits          28280    30363    +2083     
+ Misses        22279    20006    -2273     
- Partials       2828     3018     +190     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VGalaxies VGalaxies marked this pull request as ready for review July 13, 2024 07:05
@VGalaxies VGalaxies requested a review from imbajin July 13, 2024 07:05
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 13, 2024
Comment on lines -122 to -129
<!-- auto delete .flattened-pom.xml after "install" step -->
<execution>
<id>remove-flattened-pom</id>
<phase>install</phase>
<goals>
<goal>clean</goal>
</goals>
</execution>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enhance later: could add an activation (then enable it when not deploying, but only effective during installation).

@JackyYangPassion JackyYangPassion merged commit cedc000 into master Jul 13, 2024
15 of 17 checks passed
@JackyYangPassion JackyYangPassion deleted the to-1.5.0 branch July 13, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants