support disable rocksdb auto compaction through configuration #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support disable rocksdb auto compaction through configuration
dosubot
bot
added
size:S
VGalaxies
reviewed
Jul 12, 2024
| @@ -430,6 +430,9 @@ private void openRocksDB(String dbDataPath, long version) { | |||
| List<byte[]> columnFamilyBytes = RocksDB.listColumnFamilies(new Options(), dbPath); | |||
|
|
|||
| ColumnFamilyOptions cfOptions = new ColumnFamilyOptions(); | |||
| if(this.hugeConfig.get(RocksDBOptions.DISABLE_AUTO_COMPACTION)){ | |||
There was a problem hiding this comment.
consider importing the .editorconfig configuration file located at the root of the project for code formatting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2584 +/- ##
=============================================
- Coverage 52.97% 41.47% -11.50%
+ Complexity 827 493 -334
=============================================
Files 643 643
Lines 53387 53387
Branches 7018 7018
=============================================
- Hits 28280 22142 -6138
- Misses 22279 28825 +6546
+ Partials 2828 2420 -408 ☔ View full report in Codecov by Sentry. |
JackyYangPassion
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support disable rocksdb auto compaction through configuration
close #2583