-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(server): Filter dynamice path(PUT/GET/DELETE) with params cause OOM #2569
base: master
Are you sure you want to change the base?
Conversation
@SunnyBoy-WYH could u take a look for it~ |
can we merge the
|
Let’s not talk about the oom for now. for HISTOGRAM metric,seems path without param will be better.? @JackyYangPassion @imbajin |
As a consult, Do you have oom system log and ensure the oom due to this map? |
Yes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we del LOG.debug
?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2569 +/- ##
============================================
- Coverage 56.42% 1.31% -55.12%
+ Complexity 586 30 -556
============================================
Files 612 696 +84
Lines 49672 55947 +6275
Branches 6681 7049 +368
============================================
- Hits 28029 733 -27296
- Misses 18833 55161 +36328
+ Partials 2810 53 -2757 ☔ View full report in Codecov by Sentry. |
@SunnyBoy-WYH Thanks, adjust it to |
Purpose of the PR
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need