Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare for release v1.0.0 #122

Merged
merged 3 commits into from
Dec 6, 2022
Merged

chore: prepare for release v1.0.0 #122

merged 3 commits into from
Dec 6, 2022

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Dec 3, 2022

we could use git command to generate source file directly (and exclude some files by .gitattr)

git archive --format=tar.gz --output=dist/apache-hugegraph-commons/apache-hugegraph-commons-1.0.0-incubating-src.tar.gz --prefix=apache-hugegraph-commons-1.0.0-incubating-src/ release-1.0.0

and I try to unify the release steps by one script, it should be test first

@imbajin imbajin added enhancement New feature or request apache labels Dec 3, 2022
@imbajin imbajin requested review from javeme, zyxxoo and coderzc December 3, 2022 15:17
@imbajin imbajin self-assigned this Dec 3, 2022
@codecov

This comment was marked as off-topic.

@imbajin imbajin force-pushed the release-1.0.0 branch 3 times, most recently from 01be0b4 to 94c4121 Compare December 4, 2022 14:26
@imbajin
Copy link
Member Author

imbajin commented Dec 4, 2022

rebase and merge this PR, and other repo could refer this PR (modify a little comment & param)


# check whether there are new third-party dependencies by diff command,
# diff generated 'current-dependencies.txt' file with 'known-dependencies.txt' file.
diff -w -B -U0 <(sort < ${BASE_PATH}/known-dependencies.txt) \
<(sort < ${BASE_PATH}/current-dependencies.txt) > ${BASE_PATH}/result.txt
diff -w -B -U0 <(sort <"${BASE_PATH}"/known-dependencies.txt) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep the space after "<"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's better to not keep space after < or > in the shell script style (avoid < () and file_descriptor > xx error)

but keep the original style is also fine (revert it)

@zyxxoo zyxxoo merged commit a40774e into master Dec 6, 2022
@zyxxoo zyxxoo deleted the release-1.0.0 branch December 6, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apache enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants