Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat][C++] Support Date and Timestamp data type #398

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Mar 11, 2024

Proposed changes

This change add feature that support Date and Timestamp data type in C++ library.

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close #398
close #399

@acezen acezen requested a review from lixueclaire March 11, 2024 06:57
@acezen
Copy link
Contributor Author

acezen commented Mar 11, 2024

hi, @lixueclaire, can you help review this PR. This feature would not affect other data type and I would like to merge the implementation first and refactor the testing data of ldbc dataset(use the full ldbc dataset as testing), and add unit tests in another pull request.

@acezen acezen changed the title [Feat][C++] Support Timestamp data type [Feat][C++] Support Date and Timestamp data type Mar 11, 2024
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for incorporating these two new data types, which significantly enhance GraphAr's versatility. It would be highly beneficial to include some illustrative examples and ensure that the documentation is updated accordingly to reflect these additions.

@acezen
Copy link
Contributor Author

acezen commented Mar 11, 2024

Thank you for incorporating these two new data types, which significantly enhance GraphAr's versatility. It would be highly beneficial to include some illustrative examples and ensure that the documentation is updated accordingly to reflect these additions.

Thanks, I will open a new issue to include document and unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat][C++] Support Date data type
2 participants