Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Minor][C++] Revise the unsupported data type error msg to give more information #391

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

acezen
Copy link
Contributor

@acezen acezen commented Mar 7, 2024

Proposed changes

as title

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@acezen acezen requested a review from lixueclaire March 7, 2024 03:22
@acezen acezen changed the title [Minor][C++] revise the unsupported data type error msg to give more information [Minor][C++] Revise the unsupported data type error msg to give more information Mar 7, 2024
@acezen acezen requested a review from Thespica March 7, 2024 03:49
Copy link
Contributor

@lixueclaire lixueclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acezen acezen merged commit 929d8d0 into apache:main Mar 7, 2024
4 checks passed
@acezen acezen deleted the minor-revise-error-log-of-data-type branch March 7, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants