Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Include an example of converting SNAP datasets to GraphAr format #386

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

lixueclaire
Copy link
Contributor

@lixueclaire lixueclaire commented Feb 29, 2024

Proposed changes

This PR provides a sample conversion of SNAP datasets into GraphAr format, showcasing the process with the Facebook graph as a case study. The conversion leverages GraphInfo constructors and the high-level writer functions from the C++ library.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

As part of #275

@lixueclaire lixueclaire added the enhancement New feature or request label Feb 29, 2024
@lixueclaire lixueclaire requested a review from acezen February 29, 2024 06:54
@acezen
Copy link
Contributor

acezen commented Feb 29, 2024

Shell we upload the generated snap dataset of graphar format and provide a python download script to download it, like HuggingFace did?
That would easy for user to get the data directly and no need to convert by themself.

@lixueclaire
Copy link
Contributor Author

Shell we upload the generated snap dataset of graphar format and provide a python download script to download it, like HuggingFace did? That would easy for user to get the data directly and no need to convert by themself.

Certainly! This Pull Request serves as a demonstration of utilizing the GraphAr API for conversion.
In the future, we plan to make generated datasets from sources like SNAP, LDBC, or others readily available to users. These datasets will be accessible for direct download via a dedicated repository or a specialized website, as detailed in discussion #275.

@acezen
Copy link
Contributor

acezen commented Feb 29, 2024

Can you add some document about the example to docs?

@lixueclaire
Copy link
Contributor Author

Can you add some document about the example to docs?

Sure, I've created documentation for the example. Could you please review it?

Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lixueclaire lixueclaire merged commit 750c773 into apache:main Feb 29, 2024
4 checks passed
@lixueclaire lixueclaire deleted the snap-to-graphar-example branch February 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants