[Feat][Spark] Spark 3.3.x support as a Maven Profile #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ matrix strategy was incorporated into CI/CD On branch 319-spark-33x Changes to be committed: modified: .github/workflows/spark.yaml new file: spark/datasources-33/.scalafmt.conf new file: spark/datasources-33/pom.xml new file: spark/datasources-33/src/main/java/com/alibaba/graphar/GeneralParams.java new file: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/GarCommitProtocol.scala new file: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/GarDataSource.scala new file: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/GarScan.scala new file: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/GarScanBuilder.scala new file: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/GarTable.scala new file: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/GarWriterBuilder.scala new file: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/csv/CSVWriterBuilder.scala new file: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/orc/OrcOutputWriter.scala new file: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/orc/OrcWriteBuilder.scala new file: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/parquet/ParquetWriterBuilder.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/ComputeExample.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestGraphInfo.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestGraphReader.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestGraphTransformer.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestGraphWriter.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestIndexGenerator.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestReader.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestWriter.scala modified: spark/pom.xml
On branch 319-spark-33x Changes to be committed: modified: .github/workflows/spark.yaml
- update of licenserc - spark-home as a matrix variable in CI On branch 319-spark-33x Changes to be committed: modified: .github/workflows/spark.yaml modified: .licenserc.yaml
On branch 319-spark-33x Changes to be committed: modified: .github/workflows/spark.yaml modified: spark/scripts/get-spark-to-home.sh
On branch 319-spark-33x Changes to be committed: modified: .github/workflows/spark.yaml modified: spark/scripts/build.sh
On branch 319-spark-33x Changes to be committed: modified: .github/workflows/spark.yaml
- legacy.parquet.... - fieldId.read... - fieldId.write... They are required (have no idea why) to avoid NPE in spark.conf.get expressions starting from 3.3.x On branch 319-spark-33x Changes to be committed: modified: spark/graphar/src/main/scala/com/alibaba/graphar/example/GraphAr2Nebula.scala modified: spark/graphar/src/main/scala/com/alibaba/graphar/example/GraphAr2Neo4j.scala modified: spark/graphar/src/main/scala/com/alibaba/graphar/example/Nebula2GraphAr.scala modified: spark/graphar/src/main/scala/com/alibaba/graphar/example/Neo4j2GraphAr.scala
On branch 319-spark-33x Changes to be committed: modified: spark/graphar/pom.xml modified: spark/scripts/build.sh
On branch 319-spark-33x Changes to be committed: modified: spark/graphar/pom.xml
On branch 319-spark-33x Changes to be committed: modified: spark/graphar/src/main/scala/com/alibaba/graphar/importer/Neo4j.scala
acezen
reviewed
Feb 24, 2024
spark/graphar/src/main/scala/com/alibaba/graphar/importer/Neo4j.scala
Outdated
Show resolved
Hide resolved
- Update FileSystem in util - Drop non needed confs in test cases On branch 319-spark-33x Changes to be committed: modified: spark/graphar/src/main/scala/com/alibaba/graphar/example/GraphAr2Nebula.scala modified: spark/graphar/src/main/scala/com/alibaba/graphar/example/GraphAr2Neo4j.scala modified: spark/graphar/src/main/scala/com/alibaba/graphar/example/Nebula2GraphAr.scala modified: spark/graphar/src/main/scala/com/alibaba/graphar/example/Neo4j2GraphAr.scala modified: spark/graphar/src/main/scala/com/alibaba/graphar/importer/Neo4j.scala modified: spark/graphar/src/main/scala/com/alibaba/graphar/util/FileSystem.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestGraphInfo.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestGraphTransformer.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestGraphWriter.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestIndexGenerator.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestWriter.scala
|
It fails on read, not write. So, updating |
On branch 319-spark-33x Changes to be committed: modified: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/GarScan.scala modified: spark/datasources-33/src/main/scala/com/alibaba/graphar/datasources/parquet/ParquetWriterBuilder.scala modified: spark/graphar/src/main/scala/com/alibaba/graphar/util/FileSystem.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/ComputeExample.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestGraphReader.scala modified: spark/graphar/src/test/scala/com/alibaba/graphar/TestReader.scala
|
@acezen I found the right way to fix it. Sorry, it was my fault. Please, check the latest commit. |
acezen
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
As discussed in #320
spark-3.3.xwas added as a separate Maven ProfileChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Close #319