Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][C++] Add implement of property<bool> #337

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

jasinliu
Copy link
Contributor

@jasinliu jasinliu commented Jan 23, 2024

Proposed changes

As title.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

close #341
Also, I think there needs a test contains the check of all types.

@acezen
Copy link
Contributor

acezen commented Jan 24, 2024

hi, @jasinliu, can you help us to create an big issue about this problem and link this PR
to it. That would make the context clear.

@acezen
Copy link
Contributor

acezen commented Jan 24, 2024

and about the test cases fulfill, that's good advice. Can you create an issue for that too? Thanks a lot.

@acezen acezen self-requested a review January 24, 2024 02:06
@jasinliu
Copy link
Contributor Author

jasinliu commented Jan 24, 2024

hi, @jasinliu, can you help us to create an issue about this problem and link this PR to it. That would make the context clear.

OK, maybe my fault.

Copy link
Contributor

@acezen acezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~, hi, @jasinliu, if you create the related issue, please at me to merge this PR.

@jasinliu
Copy link
Contributor Author

LGTM~, hi, @jasinliu, if you create the related issue, please at me to merge this PR.

Sorry for late😂

@acezen acezen merged commit e8a304d into apache:main Jan 24, 2024
4 checks passed
@jasinliu jasinliu deleted the patch-2 branch July 30, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][C++]: Can not use property<bool>()
2 participants