-
Notifications
You must be signed in to change notification settings - Fork 566
[GLUTEN-7336][CORE] Bump Spark version to v3.5.3 #7537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI |
|
@Yohahaha can you please do a rebase? there's a small conflict on GHA script |
|
Run Gluten Clickhouse CI |
29095f0 to
f940be2
Compare
|
Run Gluten Clickhouse CI |
|
I need some time to do performance testing, maybe I'll have a chance to merge next week. |
why CH backend's performance may drop when upgrade spark version? |
It's not said that performance will decrease, it's just a standard process for upgrading versions. In fact, when upgrading to 3.5.2, we found that two TPCDS queries were a bit faster. |
f940be2 to
3eb4411
Compare
baibaichen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Run Gluten Clickhouse CI |
| <hudi.version>0.15.0</hudi.version> | ||
| <delta.version>3.2.1</delta.version> | ||
| <delta.binary.version>32</delta.binary.version> | ||
| <hudi.version>0.15.0</hudi.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming it's unintentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Have you checked the iceberg with Spark 3.5.3? It seems that Spark 3.5.3 has some problems with iceberg and the iceberg community would not support the Spark 3.5.3 release in iceberg-11160. |
no, I only check the GHA passed. IMO, Gluten only depends on Spark, we have no guarantee that gluten-iceberg will works well after this PR if iceberg has decided to skip Spark 3.5.3. |
|
can wo merge this pr first if ci passed, if there are some problems with the iceberg, will raise another pr to fix ? |
|
#7637 |
This reverts commit 94ecd9e.

What changes were proposed in this pull request?
Summary:
Fixes: #7336