Skip to content

Conversation

@Yohahaha
Copy link
Contributor

@Yohahaha Yohahaha commented Oct 15, 2024

What changes were proposed in this pull request?

Summary:

  1. bump spark version to 3.5.3
  2. disable hudi tests in GHA, [CORE] Reopen hudi GHA tests with Spark353 #7571
  3. bump delta version to 3.2.1
  4. iceberg module may breaks [CORE] Iceberg and hudi module may breaks with Spark35 #7637, but GHA was passed currently.

Fixes: #7336

@github-actions github-actions bot added the CORE works for Gluten Core label Oct 15, 2024
@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@Yohahaha Yohahaha changed the title [CORE] Bump Spark version to v3.5.3 [GLUTEN-7336][CORE] Bump Spark version to v3.5.3 Oct 15, 2024
@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

#7336

@github-actions
Copy link

Run Gluten Clickhouse CI

@zhouyuan
Copy link
Contributor

@Yohahaha can you please do a rebase? there's a small conflict on GHA script

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@zhouyuan
Copy link
Contributor

CC @baibaichen @zzcclp

@baibaichen
Copy link
Contributor

@zhouyuan

I need some time to do performance testing, maybe I'll have a chance to merge next week.

@Yohahaha
Copy link
Contributor Author

@zhouyuan

I need some time to do performance testing, maybe I'll have a chance to merge next week.

why CH backend's performance may drop when upgrade spark version?

@baibaichen
Copy link
Contributor

why CH backend's performance may drop when upgrade spark version?

It's not said that performance will decrease, it's just a standard process for upgrading versions. In fact, when upgrading to 3.5.2, we found that two TPCDS queries were a bit faster.

Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Run Gluten Clickhouse CI

<hudi.version>0.15.0</hudi.version>
<delta.version>3.2.1</delta.version>
<delta.binary.version>32</delta.binary.version>
<hudi.version>0.15.0</hudi.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it's unintentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it's Github diff issue.

image

@jackylee-ch
Copy link
Contributor

Have you checked the iceberg with Spark 3.5.3? It seems that Spark 3.5.3 has some problems with iceberg and the iceberg community would not support the Spark 3.5.3 release in iceberg-11160.

@Yohahaha
Copy link
Contributor Author

Have you checked the iceberg with Spark 3.5.3? It seems that Spark 3.5.3 has some problems with iceberg and the iceberg community would not support the Spark 3.5.3 release in iceberg-11160.

no, I only check the GHA passed.

IMO, Gluten only depends on Spark, we have no guarantee that gluten-iceberg will works well after this PR if iceberg has decided to skip Spark 3.5.3.

@zzcclp
Copy link
Contributor

zzcclp commented Oct 22, 2024

can wo merge this pr first if ci passed, if there are some problems with the iceberg, will raise another pr to fix ?

@Yohahaha Yohahaha merged commit 94ecd9e into apache:main Oct 22, 2024
@Yohahaha Yohahaha deleted the bump-spark353 branch October 22, 2024 08:53
@Yohahaha
Copy link
Contributor Author

#7637
Open above issue for gluten-iceberg if we need fix it.

Yohahaha added a commit to Yohahaha/gluten that referenced this pull request Nov 13, 2024
Yohahaha added a commit that referenced this pull request Nov 13, 2024
Revert Spark release version from v3.5.3 to v3.5.2 due to datalake issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE works for Gluten Core INFRA TOOLS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[VL] Bump Spark to 3.5.3

6 participants