[GLUTEN-11145][VL] Iceberg test supports Spark3.5 and Spark4.0#11146
Merged
jinchengchenghh merged 2 commits intoapache:mainfrom Jan 6, 2026
Merged
[GLUTEN-11145][VL] Iceberg test supports Spark3.5 and Spark4.0#11146jinchengchenghh merged 2 commits intoapache:mainfrom
jinchengchenghh merged 2 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
zhouyuan
reviewed
Nov 21, 2025
| export PATH=$JAVA_HOME/bin:$PATH | ||
| java -version | ||
| $MVN_CMD clean test -Pspark-4.0 -Pscala-2.13 -Pjava-17 -Pbackends-velox \ | ||
| -Piceberg |
Contributor
Author
There was a problem hiding this comment.
ok, Thanks!
3568558 to
e9e9a79
Compare
|
Run Gluten Clickhouse CI on x86 |
jinchengchenghh
commented
Nov 24, 2025
|
|
||
| import scala.Option; | ||
| import scala.collection.JavaConversions; | ||
| import scala.jdk.CollectionConverters; |
Contributor
Author
There was a problem hiding this comment.
Because scala 2.12 and 2.13 compatibility
jinchengchenghh
commented
Nov 24, 2025
|
|
||
| public static Dataset<Row> internalCreateDataFrame( | ||
| SparkSession spark, RDD<InternalRow> rdd, StructType schema, boolean isStreaming) { | ||
| return ((org.apache.spark.sql.classic.SparkSession) spark) |
Contributor
Author
There was a problem hiding this comment.
Need to cast to org.apache.spark.sql.classic.SparkSession
e9e9a79 to
a2c9901
Compare
|
Run Gluten Clickhouse CI on x86 |
3 similar comments
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
jinchengchenghh
commented
Nov 25, 2025
| Option<String> msg = | ||
| QueryTest.getErrorMessageInCheckAnswer( | ||
| df, JavaConversions.asScalaBuffer(rows).toSeq(), true); | ||
| df, JavaConverters.asScalaBuffer(rows).toSeq(), true); |
Contributor
Author
There was a problem hiding this comment.
For scala 2.12 and 2.13 compatibility
5e8ffe3 to
48ed4fc
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
9b4cb91 to
edc4709
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
This PR fix the unit tests facebookincubator/velox#15684 |
marin-ma
approved these changes
Jan 5, 2026
jinchengchenghh
added a commit
to jinchengchenghh/gluten
that referenced
this pull request
Jan 7, 2026
apache#11146)" This reverts commit 5f6de74.
QCLyu
pushed a commit
to QCLyu/incubator-gluten
that referenced
this pull request
Jan 8, 2026
QCLyu
pushed a commit
to QCLyu/incubator-gluten
that referenced
this pull request
Jan 8, 2026
apache#11146)" (apache#11374) This reverts commit 5f6de74.
QCLyu
pushed a commit
to QCLyu/incubator-gluten
that referenced
this pull request
Jan 8, 2026
QCLyu
pushed a commit
to QCLyu/incubator-gluten
that referenced
this pull request
Jan 8, 2026
apache#11146)" (apache#11374) This reverts commit 5f6de74.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #11145