IGNITE-13897 .NET: Service can't assign correct type to passed array parameters #8614

nizhikov · 2020-12-25T09:21:40Z

The array of user objects can't be deserialized on the java side.

The Contribution Checklist

There is a single JIRA ticket related to the pull request.
The web-link to the pull request is attached to the JIRA ticket.
The JIRA ticket has the Patch Available state.
The pull request body describes changes that have been made.
The description explains WHAT and WHY was made instead of HOW.
The pull request title is treated as the final commit message.
The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
A reviewer has been mentioned through the JIRA comments
(see the Maintainers list)
The pull request has been checked by the Teamcity Bot and
the green visa attached to the JIRA ticket (see TC.Bot: Check PR)

Notes

If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.

nizhikov · 2020-12-26T17:05:01Z

For now, we have an issue - user type arrays deserialize to Object[] on the java side during service invocation.
I fixed it in the PR.

Can you, please, take a look?

ivandasch · 2020-12-27T09:04:11Z

...s/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformUtils.java

-        Object[] res = new Object[arr.length];
+        Class<?> compType = arr.getClass().getComponentType();
+
+        Object[] res = (Object[])Array.newInstance(compType, arr.length);


Great! It was strange, that here was untyped array. Great catch!

Now that we have a check for component type above, this can be changed back to Object[] res = new Object[arr.length];

ivandasch

Looks good to me.
However there are some suspicious fails in TC
https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_PlatformNet/5807182

ivandasch

It seems, that the case if type is defined in .NET only, is now broken.
See https://ci.ignite.apache.org/buildConfiguration/IgniteTests24Java8_PlatformNetCoreLinux/5807183

PlatformComputeBinarizable2 is defined only in .NET.

.../src/main/java/org/apache/ignite/internal/processors/platform/services/PlatformServices.java

...s/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformUtils.java

nizhikov · 2020-12-28T12:13:55Z

@ivandasch

It seems, that the case if type is defined in .NET only, is now broken.

Thanks. Now it's fixed.

https://ci.ignite.apache.org/viewLog.html?buildId=5809430&buildTypeId=IgniteTests24Java8_RunAllNet

ivandasch · 2020-12-28T13:37:45Z

@ivandasch

It seems, that the case if type is defined in .NET only, is now broken.

Thanks. Now it's fixed.

https://ci.ignite.apache.org/viewLog.html?buildId=5809430&buildTypeId=IgniteTests24Java8_RunAllNet

Ok, thanks. I locally checked, it's ok. I approve PR, but lets wait for TC bot visa

ptupitsyn · 2020-12-29T08:34:47Z

...s/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformUtils.java

-        Object[] res = new Object[arr.length];
+        Class<?> compType = arr.getClass().getComponentType();
+
+        Object[] res = (Object[])Array.newInstance(compType, arr.length);


Now that we have a check for component type above, this can be changed back to Object[] res = new Object[arr.length];

…parameters (apache#8614) (cherry picked from commit c2204cd)

Merge in OSPT/ignite from net_fixes_cherry_pick to master * commit 'd6a200fed13ae8834ef1f84f275d7ff7ba71d60a': IGN-2322: Compilation fix. IGNITE-13897 .NET: Service can't assign correct type to passed array parameters (apache#8614) IGNITE-13734 .NET: Register service return type on method invocation (apache#8602) IGNITE-12824 .NET: Add BinaryConfiguration.TimestampConverter (apache#8568) IGNITE-13865 Support DateTime as a key or value in .NET and Java (apache#8580) IGNITE-10075 .NET Avoid binary configurations of Ignite Java service params (apache#8509)

…parameters (apache#8614) (cherry picked from commit c2204cd)

Merge in OSPT/ignite from net_fixes_cherry_pick to master * commit 'd6a200fed13ae8834ef1f84f275d7ff7ba71d60a': IGN-2322: Compilation fix. IGNITE-13897 .NET: Service can't assign correct type to passed array parameters (apache#8614) IGNITE-13734 .NET: Register service return type on method invocation (apache#8602) IGNITE-12824 .NET: Add BinaryConfiguration.TimestampConverter (apache#8568) IGNITE-13865 Support DateTime as a key or value in .NET and Java (apache#8580) IGNITE-10075 .NET Avoid binary configurations of Ignite Java service params (apache#8509)

…parameters (apache#8614) (cherry picked from commit c2204cd)

Merge in OSPT/ignite from net_fixes_cherry_pick to master * commit 'd6a200fed13ae8834ef1f84f275d7ff7ba71d60a': IGN-2322: Compilation fix. IGNITE-13897 .NET: Service can't assign correct type to passed array parameters (apache#8614) IGNITE-13734 .NET: Register service return type on method invocation (apache#8602) IGNITE-12824 .NET: Add BinaryConfiguration.TimestampConverter (apache#8568) IGNITE-13865 Support DateTime as a key or value in .NET and Java (apache#8580) IGNITE-10075 .NET Avoid binary configurations of Ignite Java service params (apache#8509)

nizhikov added 8 commits December 25, 2020 12:19

IGNITE-13897: Bug reproducer.

59f97db

IGNITE-13897: WIP

da985e9

Merge branch 'master' into IGNITE-13897

cbdc774

Merge branch 'master' into IGNITE-13897

9166f42

IGNITE-13897: WIP. Dirty fix of the bug.

b95f64b

IGNITE-13897: WIP. Dirty fix of the bug.

c0aebe2

IGNITE-13897: WIP. Dirty fix of the bug.

03b4085

IGNITE-13897: WIP. Dirty fix of the bug.

f096e42

nizhikov changed the title ~~IGNITE-13897 .Net: Service can't assign correct type to passed array parameters~~ IGNITE-13897 .NET: Service can't assign correct type to passed array parameters Dec 26, 2020

ivandasch reviewed Dec 27, 2020

View reviewed changes

ivandasch approved these changes Dec 27, 2020

View reviewed changes

ivandasch requested changes Dec 27, 2020

View reviewed changes

nizhikov added 2 commits December 28, 2020 11:57

IGNITE-13897: Tests fixes.

ac2deaf

IGNITE-13897: Tests fixes.

cf8bc6c

ptupitsyn requested changes Dec 28, 2020

View reviewed changes

.../src/main/java/org/apache/ignite/internal/processors/platform/services/PlatformServices.java Outdated Show resolved Hide resolved

...s/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformUtils.java Outdated Show resolved Hide resolved

IGNITE-13897: Code review fixes.

2fd079a

Merge branch 'master' into IGNITE-13897

b0f72c2

ivandasch approved these changes Dec 28, 2020

View reviewed changes

IGNITE-13897: Code review fixes.

7b97b45

ptupitsyn requested changes Dec 29, 2020

View reviewed changes

IGNITE-13897: Code review fixes.

9012c94

ptupitsyn approved these changes Dec 29, 2020

View reviewed changes

nizhikov merged commit c2204cd into master Dec 29, 2020

shishkovilja pushed a commit to shishkovilja/ignite that referenced this pull request Jan 18, 2021

IGNITE-13897 .NET: Service can't assign correct type to passed array …

cb4c28a

…parameters (apache#8614) (cherry picked from commit c2204cd)

nizhikov deleted the IGNITE-13897 branch March 19, 2021 13:24

shishkovilja pushed a commit to shishkovilja/ignite that referenced this pull request Apr 23, 2021

IGNITE-13897 .NET: Service can't assign correct type to passed array …

c73a3e4

…parameters (apache#8614) (cherry picked from commit c2204cd)

Sega76 pushed a commit to Sega76/ignite that referenced this pull request Jan 16, 2022

IGNITE-13897 .NET: Service can't assign correct type to passed array …

50baf16

…parameters (apache#8614) (cherry picked from commit c2204cd)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

IGNITE-13897 .NET: Service can't assign correct type to passed array parameters #8614

IGNITE-13897 .NET: Service can't assign correct type to passed array parameters #8614

Uh oh!

nizhikov commented Dec 25, 2020

Uh oh!

nizhikov commented Dec 26, 2020

Uh oh!

ivandasch Dec 27, 2020

Uh oh!

ptupitsyn Dec 29, 2020

Uh oh!

ivandasch left a comment •

edited

Loading

Uh oh!

ivandasch left a comment

Uh oh!

Uh oh!

Uh oh!

nizhikov commented Dec 28, 2020

Uh oh!

ivandasch commented Dec 28, 2020 •

edited

Loading

Uh oh!

ptupitsyn Dec 29, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

IGNITE-13897 .NET: Service can't assign correct type to passed array parameters #8614

IGNITE-13897 .NET: Service can't assign correct type to passed array parameters #8614

Uh oh!

Conversation

nizhikov commented Dec 25, 2020

The Contribution Checklist

Notes

Uh oh!

nizhikov commented Dec 26, 2020

Uh oh!

ivandasch Dec 27, 2020

Choose a reason for hiding this comment

Uh oh!

ptupitsyn Dec 29, 2020

Choose a reason for hiding this comment

Uh oh!

ivandasch left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivandasch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nizhikov commented Dec 28, 2020

Uh oh!

ivandasch commented Dec 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ptupitsyn Dec 29, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ivandasch left a comment •

edited

Loading

ivandasch commented Dec 28, 2020 •

edited

Loading