IGNITE-13856 make linear performance for DirectByteBufferStreamImplV2.writeString

modules/core/src/main/java/org/apache/ignite/internal/direct/stream/v2/DirectByteBufferStreamImplV2.java

@@ -22,6 +22,7 @@
 import java.util.ArrayList;
 import java.util.BitSet;
 import java.util.Collection;
+import java.util.HashMap;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
@@ -301,6 +302,9 @@ public class DirectByteBufferStreamImplV2 implements DirectByteBufferStream {
     /** */
     protected boolean lastFinished;
 
+    /** map for cashing byte-array representations of strings */
+    private Map<String, byte[]> stringsMap;
+
     /**
      * @param msgFactory Message factory.
      */
@@ -584,7 +588,29 @@ public DirectByteBufferStreamImplV2(MessageFactory msgFactory) {
 
     /** {@inheritDoc} */
     @Override public void writeString(String val) {
-        writeByteArray(val != null ? val.getBytes() : null);
+        if (val != null) {
+            if (buf.capacity() < val.length()) {
+                if (stringsMap == null)
+                    stringsMap = new HashMap<>();
+
+                byte[] bytes = stringsMap.computeIfAbsent(val, s -> s.getBytes());
+
+                try {
+                    writeByteArray(bytes);
+                }
+                catch (Exception e) {
+                    stringsMap.remove(val);
+                    throw e;
+                }
+
+                if (lastFinished)
+                    stringsMap.remove(val);
+            }
+            else
+                writeByteArray(val.getBytes());
+        }
+        else
+            writeByteArray(null);
     }
 
     /** {@inheritDoc} */

modules/core/src/test/java/org/apache/ignite/internal/direct/stream/v2/DirectByteBufferStreamImplV2ByteOrderSelfTest.java

@@ -22,6 +22,7 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Random;
+import org.apache.commons.lang3.StringUtils;
 import org.apache.ignite.IgniteException;
 import org.apache.ignite.internal.direct.stream.DirectByteBufferStream;
 import org.apache.ignite.internal.util.GridUnsafe;
@@ -339,6 +340,46 @@ public void testDoubleArrayInternal() {
         testWriteArrayInternalOverflow(arr, true, true, 3);
     }
 
+    /**
+     * tests linear performance for writeString method
+     * */
+    @Test
+    public void testLinearPerformanceForWriteString() {
+        int len = 40_000;
+
+        long t1 = getWriteStringExecutionTime(len);
+        long t2 = getWriteStringExecutionTime(len * 10);
+        long t3 = getWriteStringExecutionTime(len * 100);
+        long t4 = getWriteStringExecutionTime(len * 1000);
+
+        assertTrue(t2 <= t1 * 10);
+        assertTrue(t3 <= t1 * 100);
+        assertTrue(t4 <= t1 * 1000);
+    }
+
+    /**
+     * execution time
+     * @param len string length
+     * @return writing time
+     * */
+    private long getWriteStringExecutionTime(int len) {
+        String s = StringUtils.leftPad("1", len, "_");
+
+        buff.rewind();
+
+        DirectByteBufferStreamImplV2 stream = createStream(buff);
+
+        long d1 = System.currentTimeMillis();
+        while (!stream.lastFinished()) {
+            stream.writeString(s);
+
+            buff.rewind();
+        }
+        long d2 = System.currentTimeMillis();
+
+        return d2 - d1;
+    }
+
     /**
      * @param srcArr Source array.
      * @param writeBigEndian If {@code true}, then write in big-endian mode.