Skip to content

IGNITE-13640 copy-libs plugin added. #8406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

IGNITE-13640 copy-libs plugin added. #8406

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1df0af
IGNITE-13640 copy-libs plugin added.
sanpwc Oct 29, 2020
44d93d1
IGNITE-13640 copy-libs plugin added: changes after code review.
sanpwc Nov 2, 2020
3a17843
IGNITE-13640 copy-libs plugin added: changes after code review.
sanpwc Nov 5, 2020
9ce0d4f
IGNITE-13640 Changed lifecycle phase
sk0x50 Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions modules/opencensus/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,4 +116,27 @@
<scope>test</scope>
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>copy-libs</id>
<phase>test-compile</phase>
Copy link
Contributor

@Mmuzaf Mmuzaf Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify the following questions, please:

  • why phase test-compile instead of package?
  • all the opencensus libs will be available at libs directory by default, right? should we copy them from e.g. libs/opencensus directory only when this integration is used?

Copy link
Contributor

@sk0x50 sk0x50 Dec 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Mmuzaf ,

why phase test-compile instead of package?

Changed to package. Thank you!

all the opencensus libs will be available at libs directory by default, right?

All libs will be placed at libs/optional/ignite-opencensus in the release build.

<goals>
<goal>copy-dependencies</goal>
</goals>
<configuration>
<excludeGroupIds>org.gridgain</excludeGroupIds>
Copy link
Contributor

@Mmuzaf Mmuzaf Nov 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this? It seems all vendor-specific things must be excluded from the pom.

Copy link
Contributor Author

@sanpwc sanpwc Nov 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault. Fixed. <excludeGroupIds>org.gridgain</excludeGroupIds> -> <excludeGroupIds>org.apache.ignite</excludeGroupIds>

<outputDirectory>target/libs</outputDirectory>
<includeScope>runtime</includeScope>
<excludeTransitive>false</excludeTransitive>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>