-
Notifications
You must be signed in to change notification settings - Fork 1.9k
IGNITE-12108 TCP Communication Metrics ported to a new framework. #6814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
56b4aba
IGNITE-12108 TCP Communication Metrics ported to a new framework.
ibessonov 6bb92fa
IGNITE-12108 Checkstyle fixed.
ibessonov 414d8d7
Merge remote-tracking branch 'origin/master' into ignite-12108
ibessonov cc1145f
IGNITE-12108 nodeId replaced with consistentId for usability purposes
ibessonov 967697d
IGNITE-12108 Last review remarks.
ibessonov 3a46712
IGNITE-12108 checkstyle
ibessonov 1e652c5
Merge remote-tracking branch 'origin/master' into ignite-12108
ibessonov 6886114
IGNITE-12108 Review remarks addresses.
ibessonov 946557d
IGNITE-12108 one more change.
ibessonov 5a21644
Merge remote-tracking branch 'origin/master' into ignite-12108
ibessonov 76732cf
IGNITE-12108 Extra fields removed from GridAbstractCommunicationClient.
ibessonov 80c643d
IGNITE-12108 More review remarks fixed.
ibessonov e96a936
Merge remote-tracking branch 'origin/master' into ignite-12108
ibessonov bc35d37
IGNITE-12108 Minor code cleanup.
ibessonov ff87669
IGNITE-12108 REVERTED consistentId-based metrics.
ibessonov 7d24eb1
IGNITE-12108 assertion for tests.
ibessonov d6fffb6
IGNITE-12108 assertion removed.
ibessonov afa0e3b
Merge branch 'apache-master' into ignite-12108
ibessonov 0aa0ea0
IGNITE-12108 Avoided lookups in concurrent hash maps on every message.
ibessonov 002bd64
IGNITE-12108 HashMap replaced with Map in ThreadMetrics
ibessonov d93e7e5
IGNITE-12108 Latest review remarks addressed: removed empty catch blo…
ibessonov 284bc63
IGNITE-12108 Method inlined.
ibessonov f07eb73
IGNITE-12108 Minor refactoring.
ibessonov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
...ain/java/org/apache/ignite/internal/processors/resource/GridResourceSupplierInjector.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.ignite.internal.processors.resource; | ||
|
|
||
| import java.util.function.Supplier; | ||
| import org.apache.ignite.IgniteCheckedException; | ||
| import org.apache.ignite.internal.managers.deployment.GridDeployment; | ||
| import org.apache.ignite.internal.util.typedef.internal.S; | ||
|
|
||
| /** | ||
| * Simple injector which wraps resource object supplier. | ||
| * | ||
| * @param <T> Type of injected resource. | ||
| */ | ||
| class GridResourceSupplierInjector<T> implements GridResourceInjector { | ||
| /** Resource to inject. */ | ||
| private final Supplier<T> supplier; | ||
|
|
||
| /** | ||
| * Creates injector. | ||
| * | ||
| * @param supplier Resource supplier. | ||
| */ | ||
| GridResourceSupplierInjector(Supplier<T> supplier) { | ||
| this.supplier = supplier; | ||
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public void inject(GridResourceField field, Object target, Class<?> depCls, GridDeployment dep) | ||
| throws IgniteCheckedException { | ||
| GridResourceUtils.inject(field.getField(), target, supplier.get()); | ||
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public void inject(GridResourceMethod mtd, Object target, Class<?> depCls, GridDeployment dep) | ||
| throws IgniteCheckedException { | ||
| GridResourceUtils.inject(mtd.getMethod(), target, supplier.get()); | ||
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public void undeploy(GridDeployment dep) { | ||
| /* No-op. There is no cache. */ | ||
| } | ||
|
|
||
| /** {@inheritDoc} */ | ||
| @Override public String toString() { | ||
| return S.toString(GridResourceSupplierInjector.class, this); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need new
GridResourceSupplierInjector?Can we use existing
GridResourceBasicInejctor?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because supplier injector is lazy. In this particular place metric manager might not be initialized yet.