IGNITE-23483 : Restore snapshot check from lesser topology for snapshot check distributed process. #11596
+609
−297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng' into IGNITE-22662__snapshot_refactoring
…ng' into IGNITE-22662__snapshot_refactoring
… IGNITE-23058-Remove_snapshot_check_tasks_v2 # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java
Vladsz83
changed the title
…ng' into IGNITE-22662__snapshot_refactoring
…estore_snapshot_check_from_lesser_topology_for_snapshot_check_distributed_process # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java # modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/IgniteClusterSnapshotStreamerTest.java
Vladsz83
changed the base branch from
master
to
IGNITE-22662__snapshot_refactoring
timoninmaxim
requested changes
Dec 27, 2024
...a/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotChecker.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotChecker.java
Outdated
Show resolved
Hide resolved
timoninmaxim
requested changes
Dec 28, 2024
.../src/main/java/org/apache/ignite/internal/management/cache/VerifyBackupPartitionsTaskV2.java
Show resolved
Hide resolved
| /** @see #metas() */ | ||
| @Nullable private final List<SnapshotMetadata> metas; | ||
| /** A DTO base to transfer node's results for the both phases. */ | ||
| private abstract static class AbstractSnapshotCheckResponse<T> implements Serializable { |
There was a problem hiding this comment.
Why this class abstract, when all inheritors just use constructor. Why do you need all this classes?
There was a problem hiding this comment.
To avoid plenty of large generics in code like CompletableFuture<SnapshotCheckResponse<Map<String, Map<PartitionKeyV2, PartitionHashRecordV2>>>> and casting to them.
...n/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotChecker.java
Outdated
Show resolved
Hide resolved
…asks_v3' into IGNITE-23058_remove_snapshot_check_tasks_v3 # Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotCheckProcess.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see TC.Bot: Check PR)Notes
If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com #ignite channel.