-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Add local nightly build to test current docs changes #9943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,6 +85,26 @@ assert_not_empty () { | |
| fi | ||
| } | ||
|
|
||
| # Creates a 'nightly' version of the documentation that points to the current versioned docs | ||
| # located at the root-level `/docs` directory. | ||
| create_nightly () { | ||
| echo " --> create nightly" | ||
|
|
||
| # Remove any existing 'nightly' directory and recreate it | ||
| rm -rf docs/docs/nightly/ | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is nightly not a symlink?
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Both |
||
| mkdir docs/docs/nightly/ | ||
|
|
||
| # Create symbolic links and copy configuration files for the 'nightly' documentation | ||
| ln -s "../../../../docs/docs/" docs/docs/nightly/docs | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I verified that this works locally, but will this work on the |
||
| cp "../docs/mkdocs.yml" docs/docs/nightly/ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we make this a symlink as well? Otherwise you won't see changes made to the navigation |
||
|
|
||
| cd docs/docs/ | ||
|
|
||
| # Update version information within the 'nightly' documentation | ||
| update_version "nightly" | ||
| cd - | ||
| } | ||
|
|
||
| # Finds and retrieves the latest version of the documentation based on the directory structure. | ||
| # Assumes the documentation versions are numeric folders within 'docs/docs/'. | ||
| get_latest_version () { | ||
|
|
@@ -189,6 +209,9 @@ pull_versioned_docs () { | |
|
|
||
| # Create the 'latest' version of documentation | ||
| create_latest "${latest_version}" | ||
|
|
||
| # Create the 'nightly' version of documentation | ||
| create_nightly | ||
| } | ||
|
|
||
| # Cleans up artifacts and temporary files generated during documentation management. | ||
|
|
@@ -198,8 +221,9 @@ clean () { | |
| # Temporarily disable script exit on errors to ensure cleanup continues | ||
| set +e | ||
|
|
||
| # Remove 'latest' directories and related Git worktrees | ||
| # Remove temp directories and related Git worktrees | ||
| rm -rf docs/docs/latest &> /dev/null | ||
| rm -rf docs/docs/nightly &> /dev/null | ||
|
|
||
| git worktree remove docs/docs &> /dev/null | ||
| git worktree remove docs/javadoc &> /dev/null | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,6 +21,7 @@ nav: | |
| - Spark: spark-quickstart.md | ||
| - Hive: hive-quickstart.md | ||
| - Docs: | ||
| - nightly: '!include docs/docs/nightly/mkdocs.yml' | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm open to it, I think this was what we went with in the last discussion, but happy to bring this up. See here: #9943 (comment) CC: @danielcweeks @RussellSpitzer any thoughts here?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The label isn't what matters the most. What we care about are docs under |
||
| - latest: '!include docs/docs/latest/mkdocs.yml' | ||
| - 1.5.0: '!include docs/docs/1.5.0/mkdocs.yml' | ||
| - 1.4.3: '!include docs/docs/1.4.3/mkdocs.yml' | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1->2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: extra space before
build timeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the markdown convention of using 1 all the time. This still renders ascending numbers in the output, and doesn't require updates to numbered lists to be of concern during reviews and when updating the docs.