Build: Don't publish iceberg-open-api module #9871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajantha-bhat
reviewed
Mar 5, 2024
| } | ||
|
|
||
| subprojects { | ||
| if (it.name == 'iceberg-open-api') { |
Member
There was a problem hiding this comment.
Just wondering do we need project.hasProperty('release') check also here? Because without -Prelease it should work as usual?
Contributor
Author
There was a problem hiding this comment.
we also don't want to publish the artifact when running ./gradlew publishToMavenLocal. Exiting early here means we basically don't run any publishing/signing tasks for this particular artifact
danielcweeks
approved these changes
Mar 5, 2024
cdouglas
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 3, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.