Skip to content

Conversation

@rahil-c
Copy link
Contributor

@rahil-c rahil-c commented Mar 5, 2024

Minor revision for comments from @rdblue on the following pr: #9660

cc @jackye1995

@jackye1995
Copy link
Contributor

I think we still need to figure out GET /tables?pageToken vs GET /tables?pageToken= or both.

As I said in the old PR, in https://www.youtube.com/watch?v=uAQVGd5zV4I, starting at 45:04, seems like @rdblue said we should support both there.

And my understanding is that if we support pageToken=, then pageToken is automatically supported by default, and both presents value as empty string. It would be awkward to fail one and succeed another.

@danielcweeks
Copy link
Contributor

I didn't realize this PR was opened, but I think we should close in favor of #9872. This PR still doesn't address a number of issues that need to be clarified.

@rahil-c rahil-c closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants