Core: Add data sequence number as derived column to files metadata table #9813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dramaticlly
changed the title
zinking
reviewed
Feb 27, 2024
flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java
Show resolved
Hide resolved
Contributor
Author
|
@szehon-ho @aokolnychyi if you want to take a look? |
szehon-ho
reviewed
Feb 29, 2024
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
Thanks @dramaticlly for the work! I left some comments to see if we can make the code cleaner.
Contributor
|
Let me take a quick look today as well. |
aokolnychyi
reviewed
Apr 11, 2024
| @Override | ||
| public Schema schema() { | ||
| StructType partitionType = Partitioning.partitionType(table()); | ||
| // avoid returning an empty struct, which is not always supported. |
Contributor
There was a problem hiding this comment.
I am a bit lost with all the schemas here. Let me see if we can simplify this block.
Contributor
Author
|
closed in favor of #10203 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add data_sequence_number as derived/virtual column on all files metadata table, enables query like
without change the avro schema for files.