Nessie: Add table() and view() API to NessieIcebergClient#9477
Merged
nastra merged 1 commit intoapache:mainfrom Jan 15, 2024
Merged
Nessie: Add table() and view() API to NessieIcebergClient#9477nastra merged 1 commit intoapache:mainfrom
nastra merged 1 commit intoapache:mainfrom
Conversation
nastra
reviewed
Jan 15, 2024
| } | ||
|
|
||
| public IcebergTable table(TableIdentifier tableIdentifier) { | ||
| return (IcebergTable) fetchContent(tableIdentifier); |
Contributor
There was a problem hiding this comment.
before casting I wonder whether this should actually check whether this is actually a table and throw an error if not
Member
Author
There was a problem hiding this comment.
Instead of throwing exception, I have updated to returning null. So, that the behaviour will same as before adding the view changes.
ajantha-bhat
force-pushed
the
nessie_comp
branch
from
83f3e0c to
ff67460
Compare
nastra
approved these changes
Jan 15, 2024
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
table()inNessieIcebergClientwas renamed tofetchContent()with generic functionality while adding the view support for NessieCatalog.Nessie doesn't have to maintain compatibility as per https://iceberg.apache.org/contribute/#minor-version-deprecations-discretionary.
But while bumping Iceberg version at Trino side (trinodb/trino#20308), we concluded that it will be cleaner to have these table() and view() API.