AES GCM Stream changes #9453
Merged
AES GCM Stream changes #9453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggershinsky
commented
Jan 10, 2024
|
|
||
| if (available() <= 0 && len > 0) { | ||
| throw new EOFException(); | ||
| return -1; |
Contributor
Author
There was a problem hiding this comment.
ggershinsky
commented
Jan 10, 2024
| } | ||
|
|
||
| @Override | ||
| public long getPos() throws IOException { |
Contributor
Author
There was a problem hiding this comment.
Iceberg manifest writer calls getPos after closing the avro stream. Wrong value was returned.
rdblue
reviewed
Jan 12, 2024
| this.currentBlockIndex = 0; | ||
| this.isHeaderWritten = false; | ||
| this.lastBlockWritten = false; | ||
| this.isClosed = false; |
Contributor
There was a problem hiding this comment.
Nit: initialize finalPosition as well?
rdblue
approved these changes
Jan 14, 2024
Merged
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
adnanhemani
pushed a commit
to adnanhemani/iceberg
that referenced
this pull request
Jan 30, 2024
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.