Skip to content

[WIP] Internal relocated version of Guava #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
massdosage wants to merge 20 commits into from
Closed

[WIP] Internal relocated version of Guava #935

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
3fe69e3
first cut at providing a relocated version of guava
massdosage Apr 17, 2020
5155115
Merge branch 'master' into relocated-external-dependencies
massdosage Apr 27, 2020
01ae7ff
move shade base package from "org.apache.iceberg.shaded" to
massdosage Apr 27, 2020
2a29f57
remove dependency log
massdosage Apr 27, 2020
2e3d2db
Swap to shaded guava in common and core modules (#8)
cmathiesen Apr 29, 2020
b24ea89
Address PR comments
cmathiesen May 11, 2020
10ac582
Rename module to bundled-guava
cmathiesen May 11, 2020
69e2b37
relocate more classes
cmathiesen May 15, 2020
1b0a02f
put guava back in `versions.lock` for now
massdosage May 15, 2020
a18a15e
Merge branch 'relocated-external-dependencies' of git@github.com:Expe…
massdosage May 15, 2020
43522a2
guava should be compileOnly to prevent transitive downstream
massdosage May 15, 2020
3757546
use compileOnly for building shaded jar
massdosage May 15, 2020
933118a
Change all imports to shaded guava, update spotless plugin config
cmathiesen May 15, 2020
cc34c95
Merge branch 'master' into relocated-external-dependencies
massdosage May 18, 2020
61b6662
relocated
massdosage May 18, 2020
a900d53
merge master
massdosage May 18, 2020
fa32ad2
changes suggested by @rdblue
massdosage May 21, 2020
0e7169a
replace default jar with shaded version
massdosage May 22, 2020
6cc49aa
improved empty classifier on shadowJar
massdosage May 22, 2020
73fab7a
Updates (#10)
rdblue May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/Accessors.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg;

import com.google.common.collect.Maps;
import org.apache.iceberg.shaded.com.google.common.collect.Maps;
import java.util.List;
import java.util.Map;
import org.apache.iceberg.types.Type;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/Filterable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg;

import com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import java.util.Collection;
import org.apache.iceberg.expressions.Expression;
import org.apache.iceberg.io.CloseableIterable;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/PartitionField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg;

import com.google.common.base.Objects;
import org.apache.iceberg.shaded.com.google.common.base.Objects;
import java.io.Serializable;
import org.apache.iceberg.transforms.Transform;

Expand Down
14 changes: 7 additions & 7 deletions api/src/main/java/org/apache/iceberg/PartitionSpec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@

package org.apache.iceberg;

import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ListMultimap;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import com.google.common.collect.Multimaps;
import com.google.common.collect.Sets;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
Comment thread
rdblue marked this conversation as resolved.
Outdated
import org.apache.iceberg.shaded.com.google.common.collect.ImmutableList;
import org.apache.iceberg.shaded.com.google.common.collect.ListMultimap;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Maps;
import org.apache.iceberg.shaded.com.google.common.collect.Multimaps;
import org.apache.iceberg.shaded.com.google.common.collect.Sets;
import java.io.Serializable;
import java.io.UnsupportedEncodingException;
import java.net.URLEncoder;
Expand Down
10 changes: 5 additions & 5 deletions api/src/main/java/org/apache/iceberg/Schema.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@

package org.apache.iceberg;

import com.google.common.base.Joiner;
import com.google.common.base.Preconditions;
import com.google.common.collect.BiMap;
import com.google.common.collect.ImmutableBiMap;
import com.google.common.collect.Sets;
import org.apache.iceberg.shaded.com.google.common.base.Joiner;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.collect.BiMap;
import org.apache.iceberg.shaded.com.google.common.collect.ImmutableBiMap;
import org.apache.iceberg.shaded.com.google.common.collect.Sets;
import java.io.Serializable;
import java.util.Arrays;
import java.util.Collection;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/TableScan.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg;

import com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import java.util.Collection;
import org.apache.iceberg.expressions.Expression;
import org.apache.iceberg.io.CloseableIterable;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/Tables.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg;

import com.google.common.collect.ImmutableMap;
import org.apache.iceberg.shaded.com.google.common.collect.ImmutableMap;
import java.util.Map;

/**
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/catalog/Namespace.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.catalog;

import com.google.common.base.Joiner;
import org.apache.iceberg.shaded.com.google.common.base.Joiner;
import java.util.Arrays;

/**
Expand Down
6 changes: 3 additions & 3 deletions api/src/main/java/org/apache/iceberg/catalog/TableIdentifier.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

package org.apache.iceberg.catalog;

import com.google.common.base.Preconditions;
import com.google.common.base.Splitter;
import com.google.common.collect.Iterables;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.base.Splitter;
import org.apache.iceberg.shaded.com.google.common.collect.Iterables;
import java.util.Arrays;
import java.util.Objects;

Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/encryption/EncryptionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.encryption;

import com.google.common.collect.Iterables;
import org.apache.iceberg.shaded.com.google.common.collect.Iterables;
import java.io.Serializable;
import org.apache.iceberg.io.InputFile;
import org.apache.iceberg.io.OutputFile;
Expand Down
6 changes: 3 additions & 3 deletions api/src/main/java/org/apache/iceberg/events/Listeners.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

package org.apache.iceberg.events;

import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Maps;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
Expand Down
4 changes: 2 additions & 2 deletions api/src/main/java/org/apache/iceberg/expressions/Binder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

package org.apache.iceberg.expressions;

import com.google.common.collect.ImmutableSet;
import com.google.common.collect.Sets;
import org.apache.iceberg.shaded.com.google.common.collect.ImmutableSet;
import org.apache.iceberg.shaded.com.google.common.collect.Sets;
import java.util.List;
import java.util.Set;
import org.apache.iceberg.exceptions.ValidationException;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/expressions/BoundLiteralPredicate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.expressions;

import com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import java.util.Comparator;

public class BoundLiteralPredicate<T> extends BoundPredicate<T> {
Expand Down
4 changes: 2 additions & 2 deletions api/src/main/java/org/apache/iceberg/expressions/BoundSetPredicate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

package org.apache.iceberg.expressions;

import com.google.common.base.Joiner;
import com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.base.Joiner;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import java.util.Set;

public class BoundSetPredicate<T> extends BoundPredicate<T> {
Expand Down
4 changes: 2 additions & 2 deletions api/src/main/java/org/apache/iceberg/expressions/Expressions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

package org.apache.iceberg.expressions;

import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import java.util.stream.Stream;
import org.apache.iceberg.expressions.Expression.Operation;
import org.apache.iceberg.transforms.Transform;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/expressions/Literals.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.expressions;

import com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import java.io.ObjectStreamException;
import java.math.BigDecimal;
import java.math.RoundingMode;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/expressions/NamedReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.expressions;

import com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import org.apache.iceberg.Schema;
import org.apache.iceberg.exceptions.ValidationException;
import org.apache.iceberg.types.Types;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/expressions/Predicate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.expressions;

import com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;

public abstract class Predicate<T, C extends Term> implements Expression {
private final Operation op;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.expressions;

import com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import java.nio.ByteBuffer;
import java.util.Collection;
import java.util.Map;
Expand Down
10 changes: 5 additions & 5 deletions api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@

package org.apache.iceberg.expressions;

import com.google.common.base.Joiner;
import com.google.common.base.Preconditions;
import com.google.common.collect.Iterables;
import com.google.common.collect.Lists;
import com.google.common.collect.Sets;
import org.apache.iceberg.shaded.com.google.common.base.Joiner;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.collect.Iterables;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Sets;
import java.util.List;
import java.util.Set;
import org.apache.iceberg.exceptions.ValidationException;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/io/CloseableGroup.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.io;

import com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import java.io.Closeable;
import java.io.IOException;
import java.util.Deque;
Expand Down
6 changes: 3 additions & 3 deletions api/src/main/java/org/apache/iceberg/io/CloseableIterable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

package org.apache.iceberg.io;

import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Iterables;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.collect.ImmutableList;
import org.apache.iceberg.shaded.com.google.common.collect.Iterables;
import java.io.Closeable;
import java.io.IOException;
import java.util.Collections;
Expand Down
10 changes: 5 additions & 5 deletions api/src/main/java/org/apache/iceberg/transforms/Bucket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@

package org.apache.iceberg.transforms;

import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Objects;
import com.google.common.collect.Sets;
import com.google.common.hash.HashFunction;
import com.google.common.hash.Hashing;
import org.apache.iceberg.shaded.com.google.common.annotations.VisibleForTesting;
import org.apache.iceberg.shaded.com.google.common.base.Objects;
import org.apache.iceberg.shaded.com.google.common.collect.Sets;
import org.apache.iceberg.shaded.com.google.common.hash.HashFunction;
import org.apache.iceberg.shaded.com.google.common.hash.Hashing;
import java.math.BigDecimal;
import java.nio.ByteBuffer;
import java.nio.charset.StandardCharsets;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/transforms/Identity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.transforms;

import com.google.common.base.Objects;
import org.apache.iceberg.shaded.com.google.common.base.Objects;
import java.nio.ByteBuffer;
import org.apache.iceberg.expressions.BoundPredicate;
import org.apache.iceberg.expressions.Expressions;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/transforms/PartitionSpecVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.transforms;

import com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import java.util.List;
import org.apache.iceberg.PartitionField;
import org.apache.iceberg.PartitionSpec;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/transforms/ProjectionUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

package org.apache.iceberg.transforms;

import com.google.common.collect.Iterables;
import java.math.BigDecimal;
import java.math.BigInteger;
import org.apache.iceberg.expressions.BoundLiteralPredicate;
Expand All @@ -29,6 +28,7 @@
import org.apache.iceberg.expressions.Expression;
import org.apache.iceberg.expressions.Expressions;
import org.apache.iceberg.expressions.UnboundPredicate;
import org.apache.iceberg.shaded.com.google.common.collect.Iterables;

import static org.apache.iceberg.expressions.Expressions.predicate;

Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/transforms/Transforms.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.transforms;

import com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import java.util.Locale;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/transforms/Truncate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.transforms;

import com.google.common.base.Objects;
import org.apache.iceberg.shaded.com.google.common.base.Objects;
import java.math.BigDecimal;
import java.math.BigInteger;
import java.nio.ByteBuffer;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/types/AssignFreshIds.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.types;

import com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import java.util.Iterator;
import java.util.List;
import java.util.function.Supplier;
Expand Down
8 changes: 4 additions & 4 deletions api/src/main/java/org/apache/iceberg/types/CheckCompatibility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@

package org.apache.iceberg.types;

import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.collect.ImmutableList;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Maps;
import java.util.List;
import java.util.Locale;
import java.util.Map;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/types/Comparators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.types;

import com.google.common.collect.ImmutableMap;
import org.apache.iceberg.shaded.com.google.common.collect.ImmutableMap;
import java.nio.ByteBuffer;
import java.util.Comparator;
import org.apache.iceberg.util.UnicodeUtil;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/types/GetProjectedIds.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.types;

import com.google.common.collect.Sets;
import org.apache.iceberg.shaded.com.google.common.collect.Sets;
import java.util.List;
import java.util.Set;
import org.apache.iceberg.Schema;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/types/IndexById.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.types;

import com.google.common.collect.Maps;
import org.apache.iceberg.shaded.com.google.common.collect.Maps;
import java.util.List;
import java.util.Map;
import org.apache.iceberg.Schema;
Expand Down
6 changes: 3 additions & 3 deletions api/src/main/java/org/apache/iceberg/types/IndexByName.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@

package org.apache.iceberg.types;

import com.google.common.base.Joiner;
import com.google.common.collect.Lists;
import com.google.common.collect.Maps;
import org.apache.iceberg.shaded.com.google.common.base.Joiner;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Maps;
import java.util.Deque;
import java.util.Map;
import java.util.concurrent.Callable;
Expand Down
2 changes: 1 addition & 1 deletion api/src/main/java/org/apache/iceberg/types/PruneColumns.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

package org.apache.iceberg.types;

import com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import java.util.List;
import java.util.Set;
import org.apache.iceberg.Schema;
Expand Down
4 changes: 2 additions & 2 deletions api/src/main/java/org/apache/iceberg/types/ReassignIds.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@

package org.apache.iceberg.types;

import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
import org.apache.iceberg.shaded.com.google.common.base.Preconditions;
import org.apache.iceberg.shaded.com.google.common.collect.Lists;
import java.util.List;
import java.util.function.Supplier;
import org.apache.iceberg.Schema;
Expand Down
Loading