Skip to content

[1.4.x] JDBC Catalog: Fix namespaceExists check with special characters (#8340)#9291

Merged
nastra merged 1 commit intoapache:1.4.xfrom
ismailsimsek:1.4.x-fix_jdbc_ctalog_namespace_exists
Dec 19, 2023
Merged

[1.4.x] JDBC Catalog: Fix namespaceExists check with special characters (#8340)#9291
nastra merged 1 commit intoapache:1.4.xfrom
ismailsimsek:1.4.x-fix_jdbc_ctalog_namespace_exists

Conversation

@ismailsimsek
Copy link
Contributor

  • JDBC catalog fix namespaceExists check

(cherry picked from commit 11608e1)

…he#8340)

* JDBC catalog fix namespaceExists check

* Improve testCreateNamespace test

* Improve testCreateNamespace test

* Improve testCreateNamespace test

* Improve testCreateNamespace test

* Improve testCreateNamespace test

* Improve testCreateNamespace test

* Split tests to testCreateNamespaceWithSpecialCharacter

* Organize and split testCreateNamespace tests

* Removed test with `.`, and extended testCreateNamespaceWithBackslashCharacter

* Add review improvements

(cherry picked from commit 11608e1)
@ismailsimsek
Copy link
Contributor Author

@jbonofre @amogh-jahagirdar @nastra if its not too late Could we include this one in 1.4.3 release?

@jbonofre
Copy link
Member

@ismailsimsek we still have time. I'm reviewing it.

@nastra nastra changed the title JDBC Catalog: Fix namespaceExists check with special characters (#8340) [1.4.x] JDBC Catalog: Fix namespaceExists check with special characters (#8340) Dec 19, 2023
@nastra nastra added this to the Iceberg 1.4.3 milestone Dec 19, 2023
@nastra nastra merged commit 793f815 into apache:1.4.x Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants