Core: Use properties while initializing default HadoopFileIO for Hadoop catalog.#9283
Conversation
|
@nastra, Could you please help me with review on this? |
|
@agrawalreetika: Previously also I think only problem was properties was not considered for the default I expect PR title to be And a simple PR description. |
agrawalreetika
changed the title
|
Thank you @ajantha-bhat for the details. I have made the changes in the Title and description. |
|
PR message "to Initialise" -> to initialize |
agrawalreetika
force-pushed
the
hadoop-fileio
branch
from
677033b to
b3aeea6
Compare
| catalog.initialize("hadoop", catalogProps); | ||
| FileIO fileIO = catalog.newTableOps(tableIdent).io(); | ||
|
|
||
| Assertions.assertThat(fileIO.properties().get("warehouse")).isEqualTo("/hive/testwarehouse"); |
There was a problem hiding this comment.
| Assertions.assertThat(fileIO.properties().get("warehouse")).isEqualTo("/hive/testwarehouse"); | |
| Assertions.assertThat(fileIO.properties()).containsEntry("warehouse", "/hive/testwarehouse"); |
There was a problem hiding this comment.
this is generally better, because if the assertion ever fails, it will show the content of properties()
| FileIO fileIO = catalog.newTableOps(tableIdent).io(); | ||
|
|
||
| Assertions.assertThat(fileIO.properties().get("warehouse")).isEqualTo("/hive/testwarehouse"); | ||
| Assertions.assertThat(fileIO.properties().get("io.manifest.cache-enabled")).isEqualTo("true"); |
There was a problem hiding this comment.
| Assertions.assertThat(fileIO.properties().get("io.manifest.cache-enabled")).isEqualTo("true"); | |
| Assertions.assertThat(fileIO.properties()).containsEntry("io.manifest.cache-enabled", "true"); |
agrawalreetika
force-pushed
the
hadoop-fileio
branch
from
b3aeea6 to
cbca4ed
Compare
| this.catalogName = name; | ||
| this.warehouseLocation = LocationUtil.stripTrailingSlash(inputWarehouseLocation); | ||
|
|
||
| if (conf == null) { |
There was a problem hiding this comment.
sorry I just saw this change now. Why do we need this? I think this should be reverted
There was a problem hiding this comment.
@nastra If Hadoop Configuration is not set then subsequent would have NullPointer Excpetion. While adding the Tests I noticed we don't have conf check in HadoopCatalog the way we have it in HiveCatalog
I can explicitly initialize conf in my Tests if you think this check is not required here. Let me know.
There was a problem hiding this comment.
conf always needs to be set explicitly. This is because the HadoopCatalog (and a few others) implement Configurable
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
I think we need to revert the change that creates a conf when it was null
agrawalreetika
force-pushed
the
hadoop-fileio
branch
from
cbca4ed to
656248b
Compare
amogh-jahagirdar
left a comment
amogh-jahagirdar
left a comment
There was a problem hiding this comment.
This looks good to me, thanks @agrawalreetika !
|
Merged, thanks @agrawalreetika and thanks for reviews @nastra @ajantha-bhat ! |
5 participants
Make HadoopFileIO as default for Hadoop Catalog to initialize HadoopFileIO catalog configs similar to NessieCatalog