Core: Add StandardEncryptionManager #9277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jian Tang <[email protected]>
|
|
||
| if (FileFormat.fromString(fileFormat) != FileFormat.PARQUET) { | ||
| throw new UnsupportedOperationException( | ||
| "Iceberg encryption currently supports only parquet format for data files"); |
Member
There was a problem hiding this comment.
nit: Maybe, "Iceberg encryption for data files currently only supports parquet, default file format of $format is set as $DEFAULT_FILE_FORMAT""
Contributor
Author
There was a problem hiding this comment.
We're going to remove this anyway in the next PR since it doesn't actually prevent writing Avro or ORC files with encryption turned on.
RussellSpitzer
approved these changes
Dec 12, 2023
Member
RussellSpitzer
left a comment
RussellSpitzer
left a comment
There was a problem hiding this comment.
Looks good to me, tiny nit on the error message for invalid default data file format.
Contributor
Author
|
Thanks for the final review, @RussellSpitzer! |
Closed
lisirrx
pushed a commit
to lisirrx/iceberg
that referenced
this pull request
Jan 4, 2024
Co-Authored-By: Jian Tang <[email protected]> Co-authored-by: Gidon Gershinsky <[email protected]>
geruh
pushed a commit
to geruh/iceberg
that referenced
this pull request
Jan 26, 2024
Co-Authored-By: Jian Tang <[email protected]> Co-authored-by: Gidon Gershinsky <[email protected]>
devangjhabakh
pushed a commit
to cdouglas/iceberg
that referenced
this pull request
Apr 22, 2024
Co-Authored-By: Jian Tang <[email protected]> Co-authored-by: Gidon Gershinsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to #6884 with a few final fixes to the
StandardEncryptionManagerand related classes. This is almost entirely @ggershinsky's work, I'm just submitting this to unblock merging since he's OOO right now.