Move manifest factory methods #925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Will take a look at this today. |
rdblue
force-pushed
the
move-manifest-factory-methods
branch
from
f9e3318 to
72bd99d
Compare
Merged
aokolnychyi
reviewed
Apr 15, 2020
aokolnychyi
approved these changes
Apr 15, 2020
Contributor
aokolnychyi
left a comment
aokolnychyi
left a comment
There was a problem hiding this comment.
+1, just two questions
Contributor
Author
|
Ran tests locally and they are passing, so I'm going to merge this. |
Fokko
pushed a commit
to Fokko/iceberg
that referenced
this pull request
Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor that was part of #913, but causes that commit to change lots of files. Separating it out should be cleaner.