Update Snapshot and TableMetadata with sequence numbers #910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
v2-snapshot-metadata
branch
from
94f92d7 to
3d8e22c
Compare
Collaborator
|
Look great! +1. I will rebase #588 once this get in. |
chenjunjiedada
approved these changes
Apr 10, 2020
aokolnychyi
reviewed
Apr 10, 2020
| Preconditions.checkArgument(formatVersion == 1 || uuid != null, | ||
| "UUID is required in format v%s", formatVersion); | ||
| Preconditions.checkArgument(formatVersion > 1 || lastSequenceNumber == 0, | ||
| "Sequence number must be 0 in v1: %s", lastSequenceNumber); |
Contributor
There was a problem hiding this comment.
So, v1 writers will only be allowed to write sequence numbers as 0 and we will assume 0 as sequence numbers in metadata entities without an explicit value, correct?
Contributor
Author
There was a problem hiding this comment.
V1 writers should not pass any sequence number other than 0, and it won't get written to the file even though it is compatible. And reading v1 metadata should always fill in the sequence number with 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sequence numbers to JSON metadata in the v2 write path.