Add file_type to DataFile to support deletion file #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjunjiedada
force-pushed
the
spec-file-pos
branch
from
eca17f4 to
2b92d44
Compare
prodeezy
reviewed
Apr 6, 2020
| GenericDataFile(String filePath, FileFormat format, PartitionData partition, | ||
| long fileSizeInBytes, Metrics metrics, | ||
| ByteBuffer keyMetadata, List<Long> splitOffsets, Integer fileType) { | ||
| this(filePath, format, partition, fileSizeInBytes, metrics, splitOffsets); |
Contributor
There was a problem hiding this comment.
this can be ..
this(filePath, format, partition, fileSizeInBytes, metrics, keyMetadata, splitOffsets);
this.fileType = fileType;
.. for better reuse of code.
Collaborator
Author
There was a problem hiding this comment.
OK, no problem!
Contributor
|
Linking this PR to #824 just so this is easy to find from the issue :-) |
Collaborator
Author
|
@rdblue , Could you please help to take a look at this? |
chenjunjiedada
force-pushed
the
spec-file-pos
branch
2 times, most recently
from
8b272b2 to
39d84a0
Compare
chenjunjiedada
force-pushed
the
spec-file-pos
branch
from
39d84a0 to
d64d221
Compare
Collaborator
Author
|
Close this due to duplicated with #1030 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #359.