JDBC: JDBC Catalog should do exact namespace search for get namespace queries#8833
Closed
amogh-jahagirdar wants to merge 1 commit intoapache:mainfrom
Closed
JDBC: JDBC Catalog should do exact namespace search for get namespace queries#8833amogh-jahagirdar wants to merge 1 commit intoapache:mainfrom
amogh-jahagirdar wants to merge 1 commit intoapache:mainfrom
Conversation
amogh-jahagirdar
force-pushed
the
fix-jdbc-catalog-namespace
branch
2 times, most recently
from
59735c0 to
c81ca64
Compare
amogh-jahagirdar
force-pushed
the
fix-jdbc-catalog-namespace
branch
from
c81ca64 to
7915b99
Compare
Contributor
Author
|
Looks like a similar PR was already put up in the past #8340, we can just review that. |
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@iceberg.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8832
Currently the SQL query to get namespace does a regex based search + limit 1 , which is used during namespace existence checks. I believe this behavior is not correct, it should do an exact lookup