API, Core: Add UUID API to Table #8800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogh-jahagirdar
requested review from
Fokko,
RussellSpitzer,
danielcweeks,
nastra and
rdblue
nastra
approved these changes
Oct 11, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
this LGTM, but I think there should be a check in CatalogTests#testCompleteCreateTable() that makes sure the UUID on the table is set
jbonofre
approved these changes
Oct 11, 2023
Contributor
Author
Sure thing, I can add a test for this |
RussellSpitzer
approved these changes
Oct 11, 2023
amogh-jahagirdar
force-pushed
the
add-uuid-table-api
branch
from
5848761 to
2c9ee38
Compare
rdblue
reviewed
Oct 11, 2023
amogh-jahagirdar
force-pushed
the
add-uuid-table-api
branch
from
2c9ee38 to
d699d70
Compare
ajantha-bhat
approved these changes
Oct 17, 2023
amogh-jahagirdar
force-pushed
the
add-uuid-table-api
branch
from
d699d70 to
bd4c8a5
Compare
amogh-jahagirdar
force-pushed
the
add-uuid-table-api
branch
from
bd4c8a5 to
fdac953
Compare
nastra
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change exposes the underlying table metadata UUID via the Table API for easier access (currently one has to go through multiple hops + casting to get these details, but since a table should always have a defined UUID it will make it easier for clients to just access it via an API)