-
Notifications
You must be signed in to change notification settings - Fork 3k
AWS: Add retry logic for S3InputStream and S3OutputStream #8221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| this.skipSize = skipSize; | ||
| } | ||
|
|
||
| public static boolean shouldRetry(Exception exception) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
It feels like this adds a lot of baggage/complexity due to requiring quite a few configuration options. Also I was wondering whether we could leverage the retry behavior of the underlying S3 client by properly configuring it. The default retry behavior is shown in https://github.com/aws/aws-sdk-java-v2/blob/2.20.18/core/sdk-core/src/main/java/software/amazon/awssdk/core/internal/retry/SdkDefaultRetrySetting.java#L72-L84 and a configuration could look similar to what has been proposed in #8043 |
|
Thanks. @nastra I see what you are proposing but in our case the SDK level retry wouldn't help. Because we are using this method |
|
@danielcweeks, what are your thoughts on retries in the S3 layer? |
37128dd to
c822145
Compare
|
This pull request has been marked as stale due to 30 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the [email protected] list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. This is not a judgement on the merit of the PR in any way. It is just a way of keeping the PR queue manageable. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
@danielcweeks @jackye1995 @amogh-jahagirdar @nastra
Add retry for both S3InputStream and S3OutputStream so that when we encounter network failures (mostly SSLException for server side connection reset and SocketTimoutException for client side connection reset) or any other retriable S3 error (like throttling error), we can retry at operation level without failing the entire query.