Skip to content

Parquet: Remove duplicate test code #8098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nastra merged 3 commits into from
Nov 2, 2023
Merged

Parquet: Remove duplicate test code #8098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f62ac6b
Remove duplicate testcases from iceberg-parquet
ajantha-bhat Jul 19, 2023
2b15fef
use Junit 5
ajantha-bhat Nov 2, 2023
9abc652
Address comments
ajantha-bhat Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions parquet/src/test/java/org/apache/iceberg/avro/TestParquetReadProjection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
import org.apache.iceberg.io.FileAppender;
import org.apache.iceberg.parquet.Parquet;
import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;

public class TestParquetReadProjection extends TestReadProjection {
@Override
Expand All @@ -45,4 +47,29 @@ protected GenericData.Record writeAndRead(

return Iterables.getOnlyElement(records);
}

@Override
@Test
@Disabled("Empty struct read is not supported for Parquet")
public void testEmptyStructProjection() throws Exception {}
Copy link
Member Author

@ajantha-bhat ajantha-bhat Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests was added for Avro. When empty struct was supported. But it is not yet supported for parquet. Since both avro and parquet now use the common class. Ignoring the tests for parquet.

Copy link
Member Author

@ajantha-bhat ajantha-bhat Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, This class uses (extends) TestReadProjection from api module now. Instead of duplicated local copy.


@Override
@Test
@Disabled("Empty struct read is not supported for Parquet")
public void testEmptyStructRequiredProjection() throws Exception {}

@Override
@Test
@Disabled("Empty struct read is not supported for Parquet")
public void testRequiredEmptyStructInRequiredStruct() throws Exception {}

@Override
@Test
@Disabled("Empty struct read is not supported for Parquet")
public void testEmptyNestedStructProjection() throws Exception {}

@Override
@Test
@Disabled("Empty struct read is not supported for Parquet")
public void testEmptyNestedStructRequiredProjection() throws Exception {}
}
Loading