Core: Extend ResolvingFileIO to support BulkOperations #7976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
reviewed
Aug 4, 2023
nastra
reviewed
Aug 4, 2023
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
I think having this makes a lot of sense, just left a small comment
bryanck
reviewed
Aug 4, 2023
Co-authored-by: Eduard Tudenhoefner <[email protected]>
bryanck
reviewed
Aug 10, 2023
nastra
reviewed
Aug 10, 2023
added 3 commits
August 10, 2023 11:44
# Conflicts: # core/src/test/java/org/apache/iceberg/io/TestResolvingIO.java
dramaticlly
force-pushed
the
resolveFileIO
branch
from
a98b9ee to
8af9405
Compare
Contributor
Author
|
@RussellSpitzer @nastra @bryanck updated per your suggest, appreciate another look. |
bryanck
reviewed
Aug 10, 2023
bryanck
approved these changes
Aug 10, 2023
nastra
reviewed
Aug 11, 2023
nastra
pushed a commit
to nastra/iceberg
that referenced
this pull request
Aug 15, 2023
…pache#139) Co-authored-by: Hongyue/Steve Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #7975
Since #6682 provide major deletion performance improvement on S3 and hadoop fileIO, I think we can try to add SupportsBulkOperations for ResolvingFileIO as it currently dynamically load fileIO based on scheme and both of the delegation fileIOs (S3FileIO and HadoopFileIO) supports bulk deletion.
If custom fileIO is used at catalog but not support bulk operations, it will fall back to standup sequential deletion.
CC @rdblue @nastra @RussellSpitzer @szehon-ho