Core: Add remaining View APIs and support for InMemoryCatalog #7880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
view-apis
branch
2 times, most recently
from
9da9538 to
4f295a1
Compare
nastra
commented
Jun 23, 2023
nastra
force-pushed
the
view-apis
branch
3 times, most recently
from
582d367 to
a8a5e25
Compare
nastra
requested review from
amogh-jahagirdar,
danielcweeks,
jackye1995 and
rdblue
This was referenced Jun 29, 2023
jackye1995
reviewed
Jun 29, 2023
core/src/main/java/org/apache/iceberg/BaseMetastoreViewCatalog.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Jun 29, 2023
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Jun 29, 2023
jackye1995
reviewed
Jun 29, 2023
core/src/main/java/org/apache/iceberg/BaseMetastoreViewCatalog.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
view-apis
branch
4 times, most recently
from
0dde21e to
a5bc2a7
Compare
jackye1995
reviewed
Jun 30, 2023
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java
Outdated
Show resolved
Hide resolved
jackye1995
reviewed
Jul 3, 2023
api/src/main/java/org/apache/iceberg/view/UpdateViewRepresentation.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jul 3, 2023
api/src/main/java/org/apache/iceberg/catalog/CatalogWithViews.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Jul 3, 2023
rdblue
reviewed
Sep 26, 2023
rdblue
reviewed
Sep 26, 2023
rdblue
reviewed
Sep 26, 2023
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Sep 26, 2023
| .replaceTransaction() | ||
| .commitTransaction()) | ||
| .isInstanceOf(NoSuchTableException.class) | ||
| .hasMessageStartingWith("Table does not exist: ns.view"); |
Contributor
There was a problem hiding this comment.
This error seems a bit odd since the object does exist, it is just a view not a table. While I'd love to have a nicer error message, this probably shouldn't block getting this in. We can explore whether it is clean to have a better message later (by checking if catalog is a view catalog?).
Contributor
Author
There was a problem hiding this comment.
I've added a TODO and I'll make sure to follow up on this topic
rdblue
reviewed
Sep 26, 2023
| .withQuery("spark", "select * from ns.tbl") | ||
| .replace()) | ||
| .isInstanceOf(NoSuchViewException.class) | ||
| .hasMessageStartingWith("View does not exist: ns.table"); |
rdblue
reviewed
Sep 26, 2023
rdblue
reviewed
Sep 27, 2023
rdblue
reviewed
Sep 27, 2023
core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java
Outdated
Show resolved
Hide resolved
rdblue
reviewed
Sep 27, 2023
core/src/main/java/org/apache/iceberg/view/BaseMetastoreViewCatalog.java
Outdated
Show resolved
Hide resolved
rdblue
approved these changes
Sep 28, 2023
Contributor
|
Thanks, @nastra! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.