Core: Add create(..) method to UpdateTableRequest #7867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
update-table-req-followup
branch
from
ce5bce3 to
0c1ef49
Compare
rdblue
reviewed
Jun 23, 2023
| * validated and {@link MetadataUpdate}s that have been applied. The {@link UpdateRequirement}s and | ||
| * {@link MetadataUpdate}s can be derived from table's base and updated {@link TableMetadata} when | ||
| * using {@link TableCommit#create(TableIdentifier, TableMetadata, TableMetadata)}. | ||
| */ |
Contributor
There was a problem hiding this comment.
Can you also add Javadoc for the create method? It has requirements for the TableMetadata objects that should be noted.
Contributor
Author
There was a problem hiding this comment.
I've added the Javadoc to make this clearer when using the create method
nastra
force-pushed
the
update-table-req-followup
branch
from
0c1ef49 to
38347eb
Compare
Contributor
Author
|
Thanks for reviewing @rdblue, I've added the Javadoc to make things clearer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.