Skip to content

Parquet: Revert workaround for resource usage with zstd #7834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nastra merged 1 commit into from
Jun 14, 2023
Merged

Parquet: Revert workaround for resource usage with zstd #7834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,12 +1101,8 @@ public <D> CloseableIterable<D> build() {
conf.unset(property);
}
optionsBuilder = HadoopReadOptions.builder(conf);
// page size not used by decompressors
optionsBuilder.withCodecFactory(new ParquetCodecFactory(conf, 0));
} else {
optionsBuilder = ParquetReadOptions.builder();
// page size not used by decompressors
optionsBuilder.withCodecFactory(new ParquetCodecFactory(new Configuration(), 0));
}

for (Map.Entry<String, String> entry : properties.entrySet()) {
Expand Down
6 changes: 5 additions & 1 deletion parquet/src/main/java/org/apache/iceberg/parquet/ParquetCodecFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,12 @@

/**
* This class implements a codec factory that is used when reading from Parquet. It adds a
* workaround for memory issues encountered when reading from zstd-compressed files.
* workaround for memory issues encountered when reading from zstd-compressed files. This is no
* longer used, as Parquet 1.13 includes this fix.
*
* @deprecated will be removed in 1.5.0
*/
@Deprecated
public class ParquetCodecFactory extends CodecFactory {

public ParquetCodecFactory(Configuration configuration, int pageSize) {
Expand Down