Spark: Use UUIDUtil.convertToByteBuffer to avoid rewinding buffer #7525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
approved these changes
May 4, 2023
Contributor
rdblue
left a comment
rdblue
left a comment
There was a problem hiding this comment.
My only nit is that we never want to directly call ByteBuffer#array(). We could replace that with ByteBuffers.toByteArray but we control the incoming buffer and know that it is always safe to call array() and use it without offsets. I think the only thing I'd change here is adding a comment that says something like "Calling array() is safe because the buffer is always allocated by the thread-local".
Contributor
Author
|
Agreed, it makes sense @rdblue to add a comment. I've done that and re-pushed. Thanks for reviewing |
nastra
force-pushed
the
spark-uuid-improvements
branch
from
c7cb35d to
ce8a1d2
Compare
Contributor
Author
|
thanks for the review @rdblue, I've added a comment to make this clearer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.