Spark: Fix Failing SS ratelimit UT #7470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackye1995
approved these changes
Apr 29, 2023
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
Thanks, merging to fix master CI
Contributor
|
Thanks @singhpk234 @jackye1995 for the prompt action. |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Co-authored-by: Prashant Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the change
Post #7443). The UT of
testReadStreamOnIcebergTableWithMultipleSnapshots_WithNumberOfRows_1SS started failing, it requires a certain number of files, and hence the same handling as here . Since the CI hasn't run post merging PR this couldn't be caught.cc @jackye1995 @szehon-ho @wypoon