Delta Migration: Correct snapshotDataFilesCount in SnapshotDeltaLakeTable.Result and use Immutable to implement it
#7454
+68
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rushan Jiang <[email protected]>
Signed-off-by: Rushan Jiang <[email protected]>
Signed-off-by: Rushan Jiang <[email protected]>
Contributor
Author
|
@jackye1995 May I ask if you have time to take a look at this too? |
…tion_total_file_counter # Conflicts: # delta-lake/src/integration/java/org/apache/iceberg/delta/TestSnapshotDeltaLakeTable.java
Signed-off-by: Rushan Jiang <[email protected]>
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
snapshotDeltaLakeTable.execute()'s result,snapshotDataFilesCountonly counts data files in the most recent snapshot of the table. The intended behavior is to report the total number of data files migrated, which include those in all previous snapshots.This PR fixes this issue and use immutables to implement
SnapshotDeltaLakeTable.Resultfollowing up the #7089