Views: Move 'operation' check to ViewVersion #7428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nastra
force-pushed
the
view-version-improvement
branch
from
193e14a to
635947f
Compare
nastra
changed the title
nastra
force-pushed
the
view-version-improvement
branch
from
635947f to
72a3f89
Compare
nastra
commented
Apr 25, 2023
| * @return the string operation which produced the view version | ||
| */ | ||
| @Value.Derived | ||
| @Value.Lazy |
Contributor
Author
There was a problem hiding this comment.
@Value.Derived is eagerly computing the value before check() is executed. Switching to @Value.Lazy here so that the check() method is executed
Contributor
There was a problem hiding this comment.
@nastra, why does this matter? All that would happen is that this is set to null and then the check method throws an exception.
jackye1995
approved these changes
Apr 26, 2023
Contributor
|
Looks like there are some merge conflicts, could you rebase? |
nastra
force-pushed
the
view-version-improvement
branch
from
72a3f89 to
3c2efee
Compare
Contributor
|
Thanks for the fix! |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
(cherry picked from commit f475a6b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.