API, Core: Move schemaID from ViewRepresentation to ViewVersion and make it required #7421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I'll wait for #7417 to go in with all the cleanup and then rebase my changes. |
amogh-jahagirdar
force-pushed
the
view-version-schema
branch
from
e746b74 to
f7c2fa4
Compare
jackye1995
reviewed
Apr 24, 2023
amogh-jahagirdar
force-pushed
the
view-version-schema
branch
from
f7c2fa4 to
0c76c11
Compare
jackye1995
reviewed
Apr 25, 2023
jackye1995
approved these changes
Apr 25, 2023
Contributor
jackye1995
left a comment
jackye1995
left a comment
There was a problem hiding this comment.
looks good to me, just a nit!
amogh-jahagirdar
force-pushed
the
view-version-schema
branch
from
0c76c11 to
3ba1bcb
Compare
Contributor
|
Thanks for the quick fix! I will merge this to continue the conversations in #6559 |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
zhongyujiang
pushed a commit
to zhongyujiang/iceberg
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #6559 (comment) . The conclusion was that it's better to make schema required and part of the ViewVersion since all representations should share the same schema.