Spark -Simplify checks of output-spec-id in SparkWriteConf #7348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Contributor
Author
|
@aokolnychyi @szehon-ho this is a follow up PR to the output spec ID PR |
szehon-ho
approved these changes
Apr 14, 2023
Member
szehon-ho
left a comment
szehon-ho
left a comment
There was a problem hiding this comment.
looks good to me, ill let @aokolnychyi see if its what he had in mind.
singhpk234
approved these changes
Apr 17, 2023
Contributor
singhpk234
left a comment
singhpk234
left a comment
There was a problem hiding this comment.
LGTM as well, Thanks @gustavoatt !
aokolnychyi
approved these changes
Apr 18, 2023
Contributor
|
Thanks, @gustavoatt! Thanks for reviewing, @szehon-ho @singhpk234! |
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rely only on
Tableto verify thatoutput-spec-idis valid. This avoids having to keep the partition specs on 3.2 and 3.3 which are already present within theTable.This is a follow-up to comment #7120 (comment) in the previous PR.