Skip to content

Spark: Close the delete threads pool in some procedures like DeleteOrphan and ExpireSnapshots #7240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xloya wants to merge 4 commits into from
Closed

Spark: Close the delete threads pool in some procedures like DeleteOrphan and ExpireSnapshots #7240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
94eb3e9
close threads in some actions
Mar 30, 2023
4036c48
close threads pool in procedure and file io
Mar 31, 2023
54615dc
fix code style
Mar 31, 2023
d9f7cd0
fix suggestion
Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ....3/spark/src/main/java/org/apache/iceberg/spark/actions/DeleteOrphanFilesSparkAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,10 @@ private DeleteOrphanFiles.Result doExecute() {
LOG.info("Custom delete function provided. Using non-bulk deletes");
deleteTasks.run(deleteFunc::accept);
}

if (deleteExecutorService != null) {
deleteExecutorService.shutdown();
}
}

return ImmutableDeleteOrphanFiles.Result.builder().orphanFileLocations(orphanFiles).build();
Expand Down
4 changes: 4 additions & 0 deletions ...spark/src/main/java/org/apache/iceberg/spark/actions/DeleteReachableFilesSparkAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,10 @@ private DeleteReachableFiles.Result deleteFiles(Iterator<FileInfo> files) {
}
}

if (deleteExecutorService != null) {
deleteExecutorService.shutdown();
}

LOG.info("Deleted {} total files", summary.totalFilesCount());

return ImmutableDeleteReachableFiles.Result.builder()
Expand Down
4 changes: 4 additions & 0 deletions ...v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,6 +256,10 @@ private ExpireSnapshots.Result deleteFiles(Iterator<FileInfo> files) {
}
}

if (deleteExecutorService != null) {
deleteExecutorService.shutdown();
}

LOG.info("Deleted {} total files", summary.totalFilesCount());

return ImmutableExpireSnapshots.Result.builder()
Expand Down