[Rest Catalog Spec] Return 204 on no content response #7229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Fokko Would be great if you can help review. Thank you! |
Contributor
|
Looks like we also did similar change in #4366, @rdblue and @danielcweeks if you can help review |
Fokko
approved these changes
Apr 11, 2023
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Sorry for the late reply, I was out the last few weeks. This change makes sense to me @haizhou-zhao. I have two small suggestions to improve the clarity and consistency of the descriptions. Thanks for raising this.
Contributor
Author
|
Thanks both @dramaticlly @Fokko for your review! @Fokko Updated description based on your suggestions. Feel free to check again. |
haizhou-zhao
force-pushed
the
irc-spec
branch
3 times, most recently
from
22b1952 to
ad9b32d
Compare
Contributor
Author
|
@Fokko Let me know if you can still help with merging this PR. Thanks a lot for your help! |
nastra
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list:
tableExistsandrenameTablefrom HTTP 200 to HTTP 204Incentive:
According to RFC spec, if HTTP 200 is returned, then the response always have payload content. However, the 2 APIs above does not seem to have any return payload, for which cases, the correct success code should be 204.