MR: Fix IndexOutOfBounds by skip filter translation if there are no leaves #7123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [mr] Skip filter translation if there are no leaves (#43) * Skip filter translation if there are no leaves * Make check generic * [mr] Check for valid leaf literals * Add unit test
Contributor
Author
|
PTAL @pvary |
Contributor
Author
|
PTAL @danielcweeks - Thanks! |
edgarRd
changed the title
Contributor
|
I am not working on MR side lately, so I do not have a current knowledge of the code here |
deniskuzZ
reviewed
Apr 20, 2023
Member
deniskuzZ
left a comment
deniskuzZ
left a comment
There was a problem hiding this comment.
LGTM, note that Hive overrides this class in iceberg-handler module, due to a lack of committer support in iceberg project. Consider opening a similar PR for Hive.
pvary
approved these changes
Apr 20, 2023
Member
Contributor
|
Thanks @edgarRd for the PR and @deniskuzZ for the review! |
Contributor
Author
|
Thanks for the review @deniskuzZ and @pvary for the merge! |
zhangbutao
added a commit
to zhangbutao/hive
that referenced
this pull request
Apr 25, 2023
zhangbutao
added a commit
to zhangbutao/hive
that referenced
this pull request
Apr 25, 2023
manisin
pushed a commit
to Snowflake-Labs/iceberg
that referenced
this pull request
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7122
Handles issues when converting
SearchArgumentswhere tree and leaf arrays are not in sync.The changes in PR make sure that whenever we access certain array indexes they are within bounds expected.